docs(credits): record the #3988 carry whose merge dropped the trailer - #4432
Conversation
… [skip ci] Record #3988 by @rrmlima. Maintainer carry #4031 named the trailer in the pull-request description; the merge commit and the cherry-pick did not keep a GitHub-resolvable co-author. Forward attribution uses the account-linked noreply trailer. No history rewrite. Local suite not run (operator instruction). Co-authored-by: rrmlima <137737127+rrmlima@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change adds a follow-up section to ChangesCredits attribution
Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other · Severity of issue fixed: Low ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0360cc6d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| | Pull request | Author | Landed as | What landed | | ||
| | --- | --- | --- | --- | | ||
| | [#3988](https://github.com/lidge-jun/opencodex/pull/3988) | [@rrmlima](https://github.com/rrmlima) | [`e2bf1672c`](https://github.com/lidge-jun/opencodex/commit/e2bf1672c974611f8db736cd64a90e1dc443924a) / [`14ce693e5`](https://github.com/lidge-jun/opencodex/commit/14ce693e5846596c823941ce90add538713a25b1) | "Carries #3988 by @rrmlima (`cherry-pick -x`)" — Gemini/CCA/Vertex/AI Studio model-tail `(continue)` nudge in `messagesToGeminiFormat`. | |
There was a problem hiding this comment.
Add the promised co-author trailer
As reviewed, git cat-file -p 1a6f0f0c... contains no Co-authored-by trailer for @rrmlima, even though this change's stated purpose is to provide forward attribution for this row. CREDITS.md records the debt for readers but cannot populate GitHub's contributor graph, so the original omission remains uncorrected; add @rrmlima's account-linked noreply trailer to this commit or to the PR description before it is merged.
AGENTS.md reference: AGENTS.md:L288-L292
Useful? React with 👍 / 👎.
Summary
trailer in the pull-request description; the merge commit and the
cherry-pick (
14ce693e5, authored as an unmapped machine identity) did notkeep a GitHub-resolvable co-author. Forward attribution uses the account-linked
noreply trailer on this commit. No history rewrite.
Maintainer-integration decision
Merging under
MAINTAINERS.mdmaintainer integration intodev: documentation-onlyCREDITS.md repair, same class as #3787 / #3811. Exact-head SHA:
d0360cc6d780e0d5a497a961a5dc3ce62f6b42ad. Local suite NOT RUN (operator instruction). HostedCross-platform CI is not the verifier for this row; GraphQL
Commit.authorson thesquash object must resolve
rrmlima. This is maintainer integration, not self-approval.Verification
git log origin/dev -n 3000carry scan; GitHub GraphQLCommit.authorson14ce693e5(user: nullfor the unmapped machine author; only CommandCodeBot otherwise).rg '/pull/3988' CREDITS.mdChecklist
Made with Cursor
Summary by CodeRabbit