Skip to content

docs(credits): record the #3988 carry whose merge dropped the trailer - #4432

Merged
lidge-jun merged 1 commit into
devfrom
docs/credits-3988-rrmlima
Sep 12, 2026
Merged

lidge-jun merged 1 commit into
devfrom
docs/credits-3988-rrmlima

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

Maintainer-integration decision

Merging under MAINTAINERS.md maintainer integration into dev: documentation-only
CREDITS.md repair, same class as #3787 / #3811. Exact-head SHA: d0360cc6d780e0d5a497a961a5dc3ce62f6b42ad. Local suite NOT RUN (operator instruction). Hosted
Cross-platform CI is not the verifier for this row; GraphQL Commit.authors on the
squash object must resolve rrmlima. This is maintainer integration, not self-approval.

Verification

  • git log origin/dev -n 3000 carry scan; GitHub GraphQL Commit.authors on
    14ce693e5 (user: null for the unmapped machine author; only CommandCodeBot otherwise).
  • rg '/pull/3988' CREDITS.md
  • Local bun test / typecheck / full suite: NOT RUN (operator instruction).

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Made with Cursor

Summary by CodeRabbit

  • Documentation
    • Added a new credits entry documenting a previously missed attribution.
    • Recorded recognition for the contribution that improved continuation prompting across supported AI model integrations.
    • Clarified the relationship between the original contribution, its merged changes, and the associated attribution record.

… [skip ci]

Record #3988 by @rrmlima. Maintainer carry #4031 named the trailer in the
pull-request description; the merge commit and the cherry-pick did not keep a
GitHub-resolvable co-author. Forward attribution uses the account-linked
noreply trailer. No history rewrite. Local suite not run (operator instruction).

Co-authored-by: rrmlima <137737127+rrmlima@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 12, 2026 16:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-12T16:51:51.062914Z d0360cc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 12, 2026
@lidge-jun
lidge-jun merged commit dcd13b4 into dev Sep 12, 2026
4 of 5 checks passed
@lidge-jun
lidge-jun deleted the docs/credits-3988-rrmlima branch September 12, 2026 16:49
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e51a1b4f-0d89-4eb3-b472-d387870c6718

📥 Commits

Reviewing files that changed from the base of the PR and between 2206f96 and d0360cc.

📒 Files selected for processing (1)
  • CREDITS.md

📝 Walkthrough

Walkthrough

The change adds a follow-up section to CREDITS.md. It documents a dropped merge trailer and credits the related messagesToGeminiFormat change.

Changes

Credits attribution

Layer / File(s) Summary
Document the dropped trailer and contribution
CREDITS.md:158-173
Adds the 2026-09-13 follow-up section. It records the unmapped machine identity and credits the Gemini/CCA/Vertex/AI Studio model-tail (continue) nudge with its landing commits.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other · Severity of issue fixed: Low

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/credits-3988-rrmlima

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0360cc6d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CREDITS.md

| Pull request | Author | Landed as | What landed |
| --- | --- | --- | --- |
| [#3988](https://github.com/lidge-jun/opencodex/pull/3988) | [@rrmlima](https://github.com/rrmlima) | [`e2bf1672c`](https://github.com/lidge-jun/opencodex/commit/e2bf1672c974611f8db736cd64a90e1dc443924a) / [`14ce693e5`](https://github.com/lidge-jun/opencodex/commit/14ce693e5846596c823941ce90add538713a25b1) | "Carries #3988 by @rrmlima (`cherry-pick -x`)" — Gemini/CCA/Vertex/AI Studio model-tail `(continue)` nudge in `messagesToGeminiFormat`. |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add the promised co-author trailer

As reviewed, git cat-file -p 1a6f0f0c... contains no Co-authored-by trailer for @rrmlima, even though this change's stated purpose is to provide forward attribution for this row. CREDITS.md records the debt for readers but cannot populate GitHub's contributor graph, so the original omission remains uncorrected; add @rrmlima's account-linked noreply trailer to this commit or to the PR description before it is merged.

AGENTS.md reference: AGENTS.md:L288-L292

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant