feat(codex): add per-account auto-switch thresholds - #4020
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
⏳ DRAFT
What to do
Review readiness checklist
2/4 boxes ticked. This pull request was already a draft. Its draft status will be preserved after every issue above is resolved. |
e7923da to
c9bdeb4
Compare
c9bdeb4 to
fece6dd
Compare
리뷰 · 우선순위 56 / 80이 PR은 Codex 계정마다 사용량 기반 auto-switch 임계값을 따로 두는 기능이다. 전역 구조는 비교적 깔끔하다. 새 막히는 지점도 분명하다. draft=true, 라인 src/codex/routing.ts 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
@lidge-jun @Ingwannu — follow-up on
Could one of you review |
|
Followed up on fece6dd and the two requested source files. The account API distinguishes a missing id (existing global update) from a supplied account id, validates null/integer 0-100, rejects unknown stored accounts, and uses the current runtime config. The main-pin path uses the effective main-account threshold. I also confirmed the shared resolver is used at the current routing and subagent threshold-read sites; the global value exposed in management state is not itself a missed routing decision. This is not a full approval of the larger account/UI change. Full-root validation is still explicitly incomplete in the description, and dev now includes the #4085 startup-policy change touching the same auth-context area. Please bring this head forward without dropping that fence, finish exact-head full validation, and retain tests proving that threshold 0 disables only proactive switching, not hard-lock/cooldown/entitlement enforcement. @lidge-jun The per-account UI/product decision and sponsorship remain yours; I have not applied a sponsorship label or waived readiness based only on these two files. |
Summary
0disables proactive usage switching only for that account.Custom account thresholdaccount-card control. Inherited accounts show only the disabled toggle; the percentage appears after enablement, and native duplicate number-input arrows are hidden.Screenshot
Verification
bun run typecheckbun run privacy:scan, and PR hygiene unit tests: pass.devadvance preserved all four feature patches exactly undergit range-diff.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met: