heifsave: preserve HDR NCLX with custom ICC profiles#5140
Open
gregbenz wants to merge 1 commit into
Open
Conversation
gregbenz
marked this pull request as ready for review
July 25, 2026 21:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Preserve HDR NCLX when
heifsave(profile=...)supplies a custom ICC profile.libvips already asks libheif to write both ICC and NCLX
colrboxes when an image contains an embedded ICC profile and complete PQ or HLG CICP signaling. This extends the same behavior to an ICC profile supplied through theprofileoption.This is the focused follow-up split from #5104 during review.
Why
When
profile=attaches an ICC profile, libheif defaults to writing only onecolrbox. Without enabling its dual-profile option, the generated NCLX profile is omitted even though the image still contains complete HDR CICP signaling.This makes custom output profiles behave consistently with embedded ICC profiles and avoids losing explicit PQ or HLG color signaling when attaching a custom profile.
Test Plan
masterbecause NCLX is absent after saving withprofile=.profile=.Disclosure: I used an LLM to help prepare this change; I reviewed and tested it locally.