Add Reachable/Unreachable Nodes and Delete Nodes Screens#301
Add Reachable/Unreachable Nodes and Delete Nodes Screens#301germanferrero wants to merge 13 commits into
Conversation
|
Is there a storybook place to check into this? thanks! |
Sure, thanks for asking: https://germanferrero.github.io/lime-app/?path=/story/containers-network-nodes--network-nodes-page |
|
in the "Delete Nodes Page" the interaction in the screen appears when you select at least one node. if no node is selected, no clear call to action is defined. A way to fix it would be to have it present all the time, and in the place of how many are selected, instruct the user to select something. |
1 similar comment
|
in the "Delete Nodes Page" the interaction in the screen appears when you select at least one node. if no node is selected, no clear call to action is defined. A way to fix it would be to have it present all the time, and in the place of how many are selected, instruct the user to select something. |
|
it is not clear what the use of the connected/disconnected nodes view is... Thanks, |
|
This is related to this issue enhancement proposal libremesh/lime-packages#867 |
nicopace
left a comment
nicopace
left a comment
There was a problem hiding this comment.
thanks for the contextualization!
|
Do you need anything for this branch to be merged @germanferrero ? |
@nicopace I'm waiting to have a bit of time to address this |
|
I have some feedback: Add more information to each node in the list. I am not sure how it is best to do it but maybe we can add a button to display more information and select maybe only one column of information at a time to be desplayed. I mean, have the ability to display the hostname and its ipv4, or the hostname and its ipv6 (or board, or firmware version). This idea I think that does not shows too much information but it is very useful at the same time. Other way can be to use the "three dots" menu with "show ipv4", "show ipv6", "show ...", actions. |
germanferrero
force-pushed
the
add-network-nodes
branch
from
326ab66 to
d483240
Compare
germanferrero
changed the title
Also add a screen to mark disconnected nodes as gone chore(translations): add spanish translations for network nodes Also fix some texts keys chore(reachable-nodes): rename plugin
Currently each plugin match one to one with a menu item. We want one menu item for deleting nodes, so a plugin for it is created. In the future it will be usefull to keep related functionality in the same plugin, and allow them to have more than one menu item associated.
And complete translations
germanferrero
force-pushed
the
add-network-nodes
branch
from
d483240 to
80e050f
Compare
|
Included in #310 |
3 participants
This PR is rebased with this other one #309, checkout the latter first.
Adds Reachable/Unreachable Screen and Delete Nodes from this proposal.
Storybook delete nodes: https://germanferrero.github.io/lime-app/?path=/story/containers-remove-nodes--delete-nodes-page
Storybook reachable nodes: https://germanferrero.github.io/lime-app/?path=/story/containers-reachablenodes--reachable-nodes-page
Basically one volatile shared state db (as usual) is used to know the list of connected nodes and one persistent shared state db (new feature) is used to know the complete list of network nodes.