Conversation
rozhuk-im
commented
May 9, 2020
rozhuk-im
commented
- include posix_openpt() usage patch
- add workaround for readdir() issue: Seeking in directory stream has no effect #211
- fix few warnings
Nikratio
left a comment
Nikratio
left a comment
There was a problem hiding this comment.
Thanks for the patch! As mentioned in the other comment, I think there may be a way to avoid the need for an optional workaround. Please let me know what you think.
- include posix_openpt() usage patch - add workaround for readdir() issue: #211 - fix few warnings - Add DOCS option - remove gettext dep Upstream patches: libfuse/sshfs#212 libfuse/sshfs#211 PR: 246325 Submitted by: rozhuk.im@gmail.com git-svn-id: svn+ssh://svn.freebsd.org/ports/head@538024 35697150-7ecd-e111-bb59-0022644237b5
- include posix_openpt() usage patch - add workaround for readdir() issue: #211 - fix few warnings - Add DOCS option - remove gettext dep Upstream patches: libfuse/sshfs#212 libfuse/sshfs#211 PR: 246325 Submitted by: rozhuk.im@gmail.com
- include posix_openpt() usage patch - add workaround for readdir() issue: #211 - fix few warnings - Add DOCS option - remove gettext dep Upstream patches: libfuse/sshfs#212 libfuse/sshfs#211 PR: 246325 Submitted by: rozhuk.im@gmail.com git-svn-id: svn+ssh://svn.freebsd.org/ports/head@538024 35697150-7ecd-e111-bb59-0022644237b5
|
Are you still interested in working on this? If not, I'll close the pull request in a few days. |
|
FreeBSD already take this into ports tree :) How do you suggest to rework this? |
|
I'm happy with most of the patch, but I don't understand the need for the readdir workaround. I'd much rather see it removed from the patch and discussed separately. |
|
Are you still interested in working on this? If not, I'll close this pull request for now. |
rozhuk-im
force-pushed
the
fbsd_fixes
branch
2 times, most recently
from
df68941 to
d2623b2
Compare
- include posix_openpt() usage patch - add workaround for readdir() issue: libfuse#211, libfuse#278 - fix few warnings
|
Does pam_mount exist on FreeBSD? Otherwise I think it is better to disable the password_stdin flag. |
|
3 participants
