Repository navigation
Conversation
A missing comma joined "bad-tracknum-overflow.toc" and "bad-pretrack-isrc.toc" into one file name that doesn't exist, so neither TOC was opened and the test passed without checking them. Add the commas and raise NUM_BAD_TOCS to 11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#79 and #80 each added a bad TOC to
badtoc_fileintest/driver/cdrdao.c, but the comma between the two entries is missing. C joined them into one name,bad-tracknum-overflow.tocbad-pretrack-isrc.toc, which doesn't exist.cdio_is_tocfile()fails on a missing file, so the test reported it as correctly rejected without ever opening either TOC.This adds the commas and raises
NUM_BAD_TOCSto 11. With./cdrdao v, both TOCs are now opened and rejected for the reasons their PRs describe, andmake -C test/driver checkpasses.🤖 Generated with Claude Code