Classify p2p announcements as notifications.

include/bitcoin/node/protocols/protocol_peer.hpp

@@ -91,6 +91,8 @@ class BCN_API protocol_peer
     /// Events notification.
     /// -----------------------------------------------------------------------
 
+    using network::protocol_peer::notify;
+
     /// Set a chaser event.
     virtual void notify(const code& ec, chase event_,
         event_value value) const NOEXCEPT;

src/protocols/protocol_block_out_106.cpp

@@ -121,7 +121,7 @@ bool protocol_block_out_106::do_announce(header_t link) NOEXCEPT
 
     // bip144: get_data uses witness type_id but inv does not.
     const inventory inv{ { { type_id::block, hash } } };
-    SEND(inv, handle_send, _1);
+    NOTIFY(inv, handle_send, _1);
     return true;
 }
 

src/protocols/protocol_header_out_70012.cpp

@@ -114,7 +114,7 @@ bool protocol_header_out_70012::do_announce(header_t link) NOEXCEPT
 
     LOGN("Announce ..." << encode_hash(hash).substr(hash_size - 8, 8)
         << " to [" << opposite() << "].");
-    SEND(headers{ { ptr } }, handle_send, _1);
+    NOTIFY(headers{ { ptr } }, handle_send, _1);
     return true;
 }
 

src/protocols/protocol_transaction_out_106.cpp

@@ -118,7 +118,7 @@ bool protocol_transaction_out_106::announce(const hash_digest& hash) NOEXCEPT
 
     // bip144: get_data uses witness type_id but inv does not.
     const inventory inv{ { { type_id::transaction, hash } } };
-    SEND(inv, handle_send, _1);
+    NOTIFY(inv, handle_send, _1);
     return true;
 }
 

src/protocols/protocol_transaction_out_70013.cpp

@@ -65,7 +65,7 @@ void protocol_transaction_out_70013::do_send_fee_filter() NOEXCEPT
         return;
 
     sent_fee_ = minimum;
-    SEND(fee_filter{ minimum }, handle_send, _1);
+    NOTIFY(fee_filter{ minimum }, handle_send, _1);
 }
 
 bool protocol_transaction_out_70013::handle_chase(const code& ec,