Skip to content

Clean up license-related drift, fix linkage debug regression. #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 5 commits into from
Jul 25, 2026
Merged

Clean up license-related drift, fix linkage debug regression. #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
31dfe14
Fix debug-only regression due to new linkage +/+= operators.
evoskuil Jul 24, 2026
24f4164
Regenerate artifacts.
evoskuil Jul 24, 2026
1fd77e3
Generalize AUTHORS to match ChangeLog treatment.
evoskuil Jul 24, 2026
bed400b
Make GNU COPYING a stub, place full copy in root for scanners.
evoskuil Jul 24, 2026
e6601ab
Drop "(see AUTHORS)" from license copyright statement.
evoskuil Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
652 changes: 652 additions & 0 deletions COPYING
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 9 additions & 5 deletions builds/cmake/install-cmake.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ source_archive()
read -p "Replace '${PROJECT}' directory with intended contents? [y/N] " CONFIRM
fi

if [[ "${CONFIRM,,}" == "y" ]]; then
if [[ "$(printf '%s' "${CONFIRM}" | tr '[:upper:]' '[:lower:]')" == "y" ]]; then
remove_directory_force "${PROJECT}"
else
msg_error "Aborted installation."
Expand All @@ -573,10 +573,14 @@ source_archive()

local TAR="tar"
local WGET="wget --quiet"
local CURL="curl --fail --silent --show-error --location"

# retrieve file
${WGET} --output-document "${FILENAME}" "${URL_BASE}${FILENAME}"
# ${WGET} --output-document "${FILENAME}" "${URL_BASE}${FILENAME}"
# retrieve file, preferring wget (curl fallback for macOS)
if command -v wget >/dev/null 2>&1; then
${WGET} --output-document "${FILENAME}" "${URL_BASE}${FILENAME}"
else
${CURL} --output "${FILENAME}" "${URL_BASE}${FILENAME}"
fi

# extract to expected path
${TAR} --extract --file "${FILENAME}" --${COMPRESSION} --strip-components=1
Expand Down Expand Up @@ -637,7 +641,7 @@ source_github()
read -p "Replace '${REPOSITORY}' directory with intended contents? [y/N] " CONFIRM
fi

if [[ "${CONFIRM,,}" == "y" ]]; then
if [[ "$(printf '%s' "${CONFIRM}" | tr '[:upper:]' '[:lower:]')" == "y" ]]; then
remove_directory_force "${REPOSITORY}"
else
msg_error "Aborted installation."
Expand Down
14 changes: 9 additions & 5 deletions builds/cmake/install-presets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ source_archive()
read -p "Replace '${PROJECT}' directory with intended contents? [y/N] " CONFIRM
fi

if [[ "${CONFIRM,,}" == "y" ]]; then
if [[ "$(printf '%s' "${CONFIRM}" | tr '[:upper:]' '[:lower:]')" == "y" ]]; then
remove_directory_force "${PROJECT}"
else
msg_error "Aborted installation."
Expand All @@ -589,10 +589,14 @@ source_archive()

local TAR="tar"
local WGET="wget --quiet"
local CURL="curl --fail --silent --show-error --location"

# retrieve file
${WGET} --output-document "${FILENAME}" "${URL_BASE}${FILENAME}"
# ${WGET} --output-document "${FILENAME}" "${URL_BASE}${FILENAME}"
# retrieve file, preferring wget (curl fallback for macOS)
if command -v wget >/dev/null 2>&1; then
${WGET} --output-document "${FILENAME}" "${URL_BASE}${FILENAME}"
else
${CURL} --output "${FILENAME}" "${URL_BASE}${FILENAME}"
fi

# extract to expected path
${TAR} --extract --file "${FILENAME}" --${COMPRESSION} --strip-components=1
Expand Down Expand Up @@ -653,7 +657,7 @@ source_github()
read -p "Replace '${REPOSITORY}' directory with intended contents? [y/N] " CONFIRM
fi

if [[ "${CONFIRM,,}" == "y" ]]; then
if [[ "$(printf '%s' "${CONFIRM}" | tr '[:upper:]' '[:lower:]')" == "y" ]]; then
remove_directory_force "${REPOSITORY}"
else
msg_error "Aborted installation."
Expand Down
9 changes: 1 addition & 8 deletions builds/gnu/AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1 @@
commits libbitcoin developers
--------------------------------------------
918 Eric Voskuil (evoskuil)
262 Amir Taaki (genjix)
68 Phillip Mienk (pmienk)
5 Neill Miller (thecodefactory)
3 William Swanson (swansontec)
1 Noel Maersk (veox)
Use command 'git shortlog -sne' for latest authors log.
653 changes: 1 addition & 652 deletions builds/gnu/COPYING
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion builds/gnu/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pkgconfig_DATA = \
#------------------------------------------------------------------------------
doc_DATA = \
AUTHORS \
COPYING \
../../COPYING \
ChangeLog \
INSTALL \
NEWS \
Expand Down
4 changes: 2 additions & 2 deletions builds/gnu/configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ AC_SUBST([pkgconfigdir],[${with_pkgconfigdir}])
AC_MSG_CHECKING([--enable-ndebug option])
AC_ARG_ENABLE([ndebug],
AS_HELP_STRING([--enable-ndebug],
[Compile with NDEBUG assertion. @<:@default=no@:>@]),
[Compile with NDEBUG assertion. @<:@default=yes@:>@]),
[enable_ndebug=$enableval],
[enable_ndebug=no])
[enable_ndebug=yes])
AC_MSG_RESULT([$enable_ndebug])
AM_CONDITIONAL([ENABLE_NDEBUG], [test "x${enable_ndebug}" != "xno"])
AS_IF([test "x${enable_ndebug}" != "xno"], [AC_DEFINE([NDEBUG])])
Expand Down
18 changes: 11 additions & 7 deletions builds/gnu/install-gnu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,9 +371,9 @@ main()

# Specify or remove --enable-ndebug for gnu toolchain on release
if [[ "${BUILD_CONFIG}" == "debug" ]]; then
CONFIGURE_OPTIONS_GNU=("${CONFIGURE_OPTIONS_GNU[@]/--enable-ndebug/}")
CONFIGURE_OPTIONS_GNU=( "${CONFIGURE_OPTIONS_GNU[@]}" "--enable-ndebug=no" )
elif [[ "${BUILD_CONFIG}" == "release" ]]; then
CONFIGURE_OPTIONS=( "${CONFIGURE_OPTIONS_GNU[@]}" "--enable-ndebug" )
CONFIGURE_OPTIONS_GNU=( "${CONFIGURE_OPTIONS_GNU[@]}" "--enable-ndebug" )
fi

# Specify cmake build
Expand Down Expand Up @@ -590,7 +590,7 @@ source_archive()
read -p "Replace '${PROJECT}' directory with intended contents? [y/N] " CONFIRM
fi

if [[ "${CONFIRM,,}" == "y" ]]; then
if [[ "$(printf '%s' "${CONFIRM}" | tr '[:upper:]' '[:lower:]')" == "y" ]]; then
remove_directory_force "${PROJECT}"
else
msg_error "Aborted installation."
Expand All @@ -605,10 +605,14 @@ source_archive()

local TAR="tar"
local WGET="wget --quiet"
local CURL="curl --fail --silent --show-error --location"

# retrieve file
${WGET} --output-document "${FILENAME}" "${URL_BASE}${FILENAME}"
# ${WGET} --output-document "${FILENAME}" "${URL_BASE}${FILENAME}"
# retrieve file, preferring wget (curl fallback for macOS)
if command -v wget >/dev/null 2>&1; then
${WGET} --output-document "${FILENAME}" "${URL_BASE}${FILENAME}"
else
${CURL} --output "${FILENAME}" "${URL_BASE}${FILENAME}"
fi

# extract to expected path
${TAR} --extract --file "${FILENAME}" --${COMPRESSION} --strip-components=1
Expand Down Expand Up @@ -669,7 +673,7 @@ source_github()
read -p "Replace '${REPOSITORY}' directory with intended contents? [y/N] " CONFIRM
fi

if [[ "${CONFIRM,,}" == "y" ]]; then
if [[ "$(printf '%s' "${CONFIRM}" | tr '[:upper:]' '[:lower:]')" == "y" ]]; then
remove_directory_force "${REPOSITORY}"
else
msg_error "Aborted installation."
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/boost.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/define.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/error.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/file/file.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/file/rotator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/file/utilities.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/memory/mmap.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/memory/mmap_dispatch.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/memory/mmap_private.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/memory/mmap_storage.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/arrayhead.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/arraymap.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/body.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/hashhead.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/hashmap.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/hashmaps.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/iterator.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/keys.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/linkage.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/nohead.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/nomap.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/primitives/nomaps.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/query/address/address_balance.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/query/address/address_history.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/query/address/address_outpoints.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/query/address/address_unspent.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/query/amounts.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/query/archive/chain_reader.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/query/archive/chain_writer.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/query/archive/wire_reader.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
7 changes: 5 additions & 2 deletions include/bitcoin/database/impl/query/archive/wire_writer.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down Expand Up @@ -326,7 +326,10 @@ code CLASS::set_code(const block_view& block, const header_link& key,
fks.outs_fk += tx.outputs();
fks.in_fk += tx.input_table_size();
fks.out_fk += out_bytes;
fks.ad_fk += tx.outputs();

// Unallocated (disabled) address link is terminal (do not increment).
if (address)
fks.ad_fk += tx.outputs();
}

// Release all accessors (subsequent writes allocate).
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/query/batch/ecdsa.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/database/impl/query/batch/prevalid.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2011-2026 libbitcoin developers (see AUTHORS)
* Copyright (c) 2011-2026 libbitcoin developers
*
* This file is part of libbitcoin.
*
Expand Down
Loading
Loading