Fix System::get_info() on uninitialized systems#4400
Open
roystgnr wants to merge 2 commits intolibMesh:develfrom
Open
Fix System::get_info() on uninitialized systems#4400roystgnr wants to merge 2 commits intolibMesh:develfrom
roystgnr wants to merge 2 commits intolibMesh:develfrom
Conversation
Most code doesn't do this, but when a code does it should still get some info, not just an assertion failure or a segfault.
Member
Author
|
Actually, this might have been due to a behavioral change elsewhere, an app's post- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what regressed this - the last time we added more output to
get_info()? TheDofMapBaserefactoring? But currently if you callget_info()on an uninitialized system it will fail in then_local_dofs()call, because_first_dfhasn't even been resized yet.Arguably
DofMapBasecalls like that should also be made more robust in the uninitialized case, but asking for data that obviously depends on initialization feels more avoidable at the application level than asking for a general info summary.