Repository navigation
deps: bound curl_cffi below 0.17 (impersonated requests lose their User-Agent) - #5
Merged
Merged
Conversation
The CI installs the extras from pyproject.toml, not from the lock, and now gets curl_cffi 0.17.0. With 0.17.0, test_imitation_envoie_une_empreinte_de_navigateur fails: the impersonated request sends no User-Agent. The lock pins 0.16.3. The bound keeps the CI on the tested version until the code is adapted to 0.17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The CI installs the extras from
pyproject.toml(curl_cffi>=0.15), not fromrequirements*.lock. It now gets curl_cffi 0.17.0, andtests/test_tls_fingerprint.py::test_imitation_envoie_une_empreinte_de_navigateurfails on Python 3.11 and 3.13: the impersonated request reaches the server without aUser-Agent(assert 'Chrome' in ''). The lock pins 0.16.3, the version the code was tested with. The last green run onmainis from 25 October, before 0.17.0.What
curl_cffi>=0.15,<0.17inpyproject.toml. Adapting_http.aimpersonate_getto 0.17 is a separate change.Failing first
The failing run is on PR #4 (unrelated change): https://github.com/lfoletti/accesspath/actions/runs/41875669170 — the same test fails there with curl_cffi 0.17.0. This PR's CI is the proof that the bound restores it.