Remove leave-aware dispatcher continuation#1907
Open
Th0rgal wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
| \n### CI Failure Hints\n\nFailed jobs: `checks`\n\nCopy-paste local triage:\n```bash\nmake check\nlake build\nFOUNDRY_PROFILE=difftest forge test -vv\n``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LeaveAwareCallDispatcherContinuationfrom EndToEnd.hContpremise from the E2/E4/E6 and F2/F4/F6 success bridge wrappers.Stacked on #1906.
Verification
lake env lean --stdinpassed on the stacked branch.lake build Compiler.Proofs.EndToEndNote
Medium Risk
Touches core end-to-end correctness proofs and changes theorem premises (removing
hContand switching to the final-matched dispatcher endpoint), which may break downstream proof consumers despite being mechanically checked by Lean.Overview
Simplifies the selector-hit end-to-end proof chain by deleting the bespoke
LeaveAwareCallDispatcherContinuationhypothesis and removing the extrahContpremise from the E2/E4/E6 and F2/F4/F6 success-bridge wrappers.Updates
nativeGeneratedSelectorHit_success_of_user_body_exec_bridge_atFuel_revivedLeaveAware_and_continuationto consume the generated..._finalMatcheddispatcher endpoint directly by deriving the needed case-body execution and final matched-flag facts from the revived exec bridge, and adjusts the publicnativeGeneratedCallDispatcherMatchesIR_of_compile_ok_supported/ core preservation theorem to take the unifiedNativeGeneratedSelectedUserBodyResultBridgeAtFuelinstead of the older halt-only bridge.Reviewed by Cursor Bugbot for commit ec68085. Bugbot is set up for automated code reviews on this repo. Configure here.