demo: Silicon Live FPGA evidence TUI - #22
Conversation
|
@codex review Please perform a fresh review of exact head |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ee727a12e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| term.update(f"[#80d98b b]PREFIX MATCH ✓[/] [#d7f4dc]expected execution prefix reproduced exactly[/]\n" | ||
| f"[#9aa3b2]evidence replay · no board[/] [#f0c36a]LIMITATION —[/] {ev.reason}") |
There was a problem hiding this comment.
When a compatible evidence file has a response or final-memory mismatch, Replay sets terminal to MISMATCH, but this branch unconditionally renders PREFIX MATCH ✓ and says the prefix was reproduced exactly. The error class does not correct the false result text, so failed evidence is presented as successful; render the success card only for the prefix-match terminal and show the actual failure otherwise.
Useful? React with 👍 / 👎.
| tag = "[on #5a451e #ffe2a1 b] READ [/]" if active and address in active.reads else ( | ||
| "[on #214b2c #aaf5b4 b] WRITE[/]" if active and address in active.writes else " ") | ||
| exact = f"{value:032x}" | ||
| grouped = f"{exact[:8]} · {exact[8:16]} · {exact[-8:]}" |
There was a problem hiding this comment.
For a compatible evidence file whose u128 cells have nonzero bits in the third eight-digit group, this formatting displays only exact[0:16] and exact[24:32], silently omitting exact[16:24]. Distinct 128-bit values can therefore appear identical in the panel labeled as exact; include all four eight-digit groups.
Useful? React with 👍 / 👎.
1 participant
Summary
silicon_live/python3 -m silicon_live --demoPREFIX MATCH ✓rather than PASSSafety and scope
Exact starting base:
bae5e4e3edaa5447210b66992466bddea6520394. All implementation and documentation paths are insidesilicon_live/. The sole unavoidable exception is rootSHA256SUMS: the repository CI requires its mechanically generated file manifest to include every new tracked file. It changes no runtime, protocol, RTL, or FPGA behavior. No hardware, JTAG, UART load, merge, rebase, or force-push.Tests
72 passed, 1 skipped, 15 subtests passed in 11.98sVisual evidence
silicon_live/docs/screenshots/01-initial-shell.svgsilicon_live/docs/screenshots/02-active-middle-step.svgsilicon_live/docs/screenshots/03-narrow-terminal.svgsilicon_live/docs/screenshots/04-prefix-match.svgsilicon_live/docs/VISUAL_QA.md