bad-key-revoker: earlier check for too many affected certs - #8987
Open
aarongable wants to merge 3 commits into
Open
bad-key-revoker: earlier check for too many affected certs#8987aarongable wants to merge 3 commits into
aarongable wants to merge 3 commits into
Conversation
The bad-key-revoker refuses to process a row if the resulting affected certificate set is going to be too large: in such cases, we want the revocation to be manually reviewed. However, it currently computes the full affected certificate set before ever comparing the size of that set to the threshold. This means that it could spend excessive database time querying for affected certificates even when it already knows that it won't proceed with automated revocation. Move the check against the maxRevocations threshold inside the loop, so it will bail out earlier in such cases.
beautifulentropy
approved these changes
Aug 27, 2026
beautifulentropy
requested review from
a team and
jsha
and removed request for
a team
August 27, 2026 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bad-key-revoker refuses to process a row if the resulting affected certificate set is going to be too large: in such cases, we want the revocation to be manually reviewed. However, it currently computes the full affected certificate set before ever comparing the size of that set to the threshold. This means that it could spend excessive database time querying for affected certificates even when it already knows that it won't proceed with automated revocation.
Move the check against the maxRevocations threshold inside the loop, so it will bail out earlier in such cases.