mtca/publisher: make MirrorID nullable - #8968
Merged
Merged
Conversation
This field is null when a checkpoint is first created. Represent it as a
`*string`. This fixes a unittest error I was seeing locally:
--- FAIL: TestPublish (0.01s)
mtpublisher_test.go:190: p.Publish(): selecting the latest checkpoint: failed to select one *mtpublisher.checkpointEntry (unknown table): sql: Scan error on column index 3, name "mirrorID": converting NULL to string is unsupported
aarongable
approved these changes
Aug 28, 2026
aarongable
left a comment
aarongable
left a comment
Contributor
There was a problem hiding this comment.
LGTM, note that this will have merge conflicts with #8971
beautifulentropy
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This field is null when a checkpoint is first created. Represent it as a
*string. This fixes a unittest error I was seeing locally: