test: Add coverage for :is()/:matches() containing nested :has() selectors#4422
Draft
test: Add coverage for :is()/:matches() containing nested :has() selectors#4422
Conversation
Co-authored-by: matthew-dean <414752+matthew-dean@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ParseError with :is() or :matches() containing :has()
test: Add coverage for :is()/:matches() containing nested :has() selectors
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser threw
ParseError: Missing closing ')'when parsing pseudo-selectors like:is(:not(:has(>.foo)), :has(>.foo.bar)), despite the parentheses being balanced. The fix was already applied in PR #4290 (changing the element fallback parser to loop through comma-separated selector lists rather than expecting a single selector before)), but the specific scenario from this issue had no test coverage.Changes
tests-unit/selectors/selectors.less— Added test cases for::is(:not(:has(>.foo)), :has(>.foo.bar))— the exact failing case:matches(:not(:has(>.foo)), :has(>.foo.bar))—:matches()variant:is(:has(>.foo + .bar), :has(>.baz ~ .qux), :not(:has(.quux)))— multiple complex nested:has()argumentstests-unit/selectors/selectors.css— Corresponding expected outputOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.