fix(P4): replace per-call ObjectMapper with Spring-managed bean - #73
Merged
Merged
Conversation
AgentRegistrar, HeartbeatSender, and LlmClient each created new ObjectMapper() on every call. Inject the Spring-managed ObjectMapper bean instead — thread-safe, properly configured with JavaTimeModule, and reused across the application lifecycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces per-call
new ObjectMapper()instances with the Spring-managed bean across three classes.Problem
AgentRegistrar,HeartbeatSender, andLlmClienteach creatednew ObjectMapper()on every HTTP call. ObjectMapper is expensive to construct and thread-safe once configured — creating throwaway instances wastes CPU and ignores the application's configured Jackson modules (JavaTimeModule, etc.).Fix
AgentRegistrar.javaObjectMappervia constructor; use it forwriteValueAsStringandreadTreeHeartbeatSender.javaObjectMappervia constructor; use it forwriteValueAsStringLlmClient.javaObjectMappervia constructor instead ofnew ObjectMapper()All three classes are
@Components in a Spring Boot context — the auto-configured primaryObjectMapperbean (withJavaTimeModuleregistered) is injected automatically.