Fix issue #1048: Add null pointer check in XMLDocument::DeleteNode#1057
Merged
leethomason merged 1 commit intoleethomason:masterfrom Mar 10, 2026
Merged
Conversation
Contributor
zhthhh
commented
Dec 7, 2025
zhthhh
commented
- Add null pointer check in XMLDocument::DeleteNode() method
- Add test case to verify null pointer handling
- Prevents segmentation fault when calling DeleteNode(nullptr)
…leteNode - Add null pointer check in XMLDocument::DeleteNode() method - Add test case to verify null pointer handling - Prevents segmentation fault when calling DeleteNode(nullptr)
Contributor
Author
|
I have added null pointer tests for the DeletNode function. Previously, passing a null pointer to DeletNode in the release build would cause a segmentation fault. With this modification, a safe return logic has been implemented to handle such cases. |
kanompiebear-arch
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.