Skip to content

chore: clean up include paths - #2175

Merged
leejet merged 1 commit into
leejet:masterfrom
wbruna:sd_clean_include
Oct 20, 2026
Merged

leejet merged 1 commit into
leejet:masterfrom
wbruna:sd_clean_include

Conversation

@wbruna

@wbruna wbruna commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • do not propagate src to examples
  • remove top-level include, since nothing depends on it

Checklist

Summary by CodeRabbit

  • Refactor
    • Reorganized internal include directory visibility for the stable-diffusion build target without changing exported or public interfaces.

* do not propagate src to examples
* remove top-level include, since nothing depends on it
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: df3d9da2-46db-4dd4-b391-4975369ef8df
📥 Commits

Reviewing files that changed from the base of the PR and between b13a482 and 5d231b6.

📒 Files selected for processing: 1
  • CMakeLists.txt

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The stable-diffusion CMake target’s include directories were reorganized. The project root was removed from the include paths, and src and src/core are private.

Changes: CMake Target Includes

Layer / File(s) Summary
Update target include directories
CMakeLists.txt
The target retains include and thirdparty as public include directories. It sets src and src/core as private include directories and removes the project root from the include paths.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Suggested reviewers: leejet

Merge Risk: ⚪ Minimal · up to 5d231

No actionable merge-blocking risk remains; normal build validation is still appropriate.

Architecture risk: 🔵 Low · up to 5d231

The change affects 1 system.

Changed systems: CMakeLists.txt

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — CMakeLists.txt (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in CMakeLists.txt: Updated stable-diffusion include-directory visibility and paths by removing the project-root include entries, making src private alongside src/core, and retaining include and thirdparty as public directories.
Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly describes the include-path cleanup and matches the main changes.
Description check Passed The description includes a focused Summary and a completed Checklist. It omits the Related Issue / Discussion and Additional Information sections, but the required change and contribution-guideline co…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes a focused Summary and a completed Checklist. It omits the Related Issue / Discussion and Additional Information sections, but the required change and contribution-guideline confirmation are clear.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@leejet
leejet merged commit 2005081 into leejet:master Oct 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants