Skip to content

Fix --sigmas for sd-server qwen image 2.1 so passing flags works on webui - #2172

Merged
leejet merged 1 commit into
leejet:masterfrom
crystalsighting:master
Oct 20, 2026
Merged

leejet merged 1 commit into
leejet:masterfrom
crystalsighting:master

Conversation

@crystalsighting

@crystalsighting crystalsighting commented Oct 20, 2026 •

Copy link
Copy Markdown

Fixes qwen image 2.1 on webui so that sd-server with --sigmas "qwen-image-2.1-turbo" works when generating from webui, or any sigma you want.

Checklist

Summary by CodeRabbit

  • Bug Fixes
    • Empty custom_sigmas arrays no longer override server or command-line defaults.
    • Non-empty custom_sigmas arrays continue to replace the configured sigma values.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0da6f827-f471-4c3c-84ad-ced073df1fcb
📥 Commits

Reviewing files that changed from the base of the PR and between b13a482 and 836fd8e.

📒 Files selected for processing: 1
  • examples/common/common.cpp

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The JSON parser now ignores empty custom_sigmas arrays. Non-empty arrays still replace the target sigma values.

Changes: Custom sigma JSON handling

Layer / File(s) Summary
Apply non-empty custom sigma arrays
examples/common/common.cpp
The parser loads custom_sigmas only when it is an array with at least one element. Empty arrays no longer overwrite existing sigma settings.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: leejet

Merge Risk: ⚪ Minimal · up to 836fd

The sigma handling change matches the stated behavior and presents no actionable merge-blocking risk.

Architecture Summary

Architecture risk: 🔵 Low · up to 836fd

The change affects 1 system.

Changed systems: examples

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — examples (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in examples/common/common.cpp: custom_sigmas is now loaded only when the JSON value is an array containing at least one element; empty arrays no longer overwrite existing or default sigma settings.
Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly describes the fix to --sigmas handling for Qwen Image 2.1 in sd-server and webui.
Description check Passed The description explains the change and expected behavior, and it includes the completed checklist. The optional Related Issue / Discussion and Additional Information sections are not included.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@leejet
leejet merged commit 269045e into leejet:master Oct 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants