remove std::exit #1161
Closed
remove std::exit #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safer regarding memory allocation
exception for -h about invalid arg (in common.hpp parse_options)
piallai
added a commit
to piallai/stable-diffusion.cpp
that referenced
this pull request
Jan 4, 2026
Owner
|
Since sd-cli is a CLI-only program, using std::exit in argument parsing is reasonable and not a problem. |
Contributor
Author
|
Indeed. Actually std::exit has a radical behaviour (hard exit no matter what) that is not compatible with my fork. So it was just to propose a way to also make the repo safer in a general manner. But you're right, it does not change much the original cli behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safer regarding memory allocation
Caution: indentation was not changed in 'main', for diff clarity sake