[19.0][FIX] attachment_preview: extend AttachmentButtons, not the removed aside - #14
Open
dnplkndll wants to merge 1 commit into
Open
Conversation
Odoo 19 removed o-mail-AttachmentCard-aside, so the inheritance cannot resolve and the whole Chatter fails to render on any record with an attachment. Extend the o-mail-AttachmentButtons hover group instead, where the per-attachment actions now live, and match its button styling. Keep both buttons: _onPreviewAttachment reads data-target and treats anything but "new" as split-screen. Also apply the manifest author spacing requested in review. Assisted-by: Claude Opus 5
dnplkndll
force-pushed
the
19.0-fix-attachment_preview-attachmentlist-xpath
branch
from
September 4, 2026 18:14
1421e57 to
a20eb39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for OCA#588. Based on
19.0-mig-attachment_preview(pinned at091d58a0, that PR's head) so the diff is only the fix.Odoo 19 removed
o-mail-AttachmentCard-aside, so the inheritance cannot resolve and the whole Chatter fails to render on any record with an attachment. This extendso-mail-AttachmentButtonsinstead, where the per-attachment actions now live.Both buttons are kept —
_onPreviewAttachmentreadsdata-targetand treats anything but"new"as split-screen. Also applies the manifest author spacing requested in review on OCA#588.Note that OCA#588's checks are green: the failure is a client-side OWL error, so the server-side tests cannot catch it. Reproduce by installing the module and opening any record with an attachment.
Preview stays desktop-only, as
o-mail-AttachmentButtonsis!isMobileOS— same as Download and Remove.