Add submission details modal#5716
Add submission details modal#5716AlexVelezLl wants to merge 24 commits intolearningequality:unstablefrom
Conversation
There was a problem hiding this comment.
By any chance, would StudioAccordion fit the use-case? (we did lots of work around a11y there and it's fairly general)
There was a problem hiding this comment.
Also feel free to adjust it for this use-case if needed. Right now it's used on Catalog FAQ page
There was a problem hiding this comment.
This is a question-question, not a question-suggestion. I don't know how user experience looks like here :)
There was a problem hiding this comment.
Hi @MisRob! Thanks for noticing! Yes, the UX here is super different. They are basically something like "expandable containers", which... actually made me think that perhaps "accordion" is not the best wording here 😅. But I definitely forgot some of the accessibility implications of these "see all"/"see less" buttons. Will push a commit to fix this! Thanks!
There was a problem hiding this comment.
Seems to be a disclosure then? https://www.w3.org/WAI/ARIA/apg/patterns/disclosure
There was a problem hiding this comment.
Then yes renaming at the very least would be helpful, I believe
AlexVelezLl
force-pushed
the
new-channel-details
branch
from
fbafc5c to
e32b7f7
Compare
3 participants
Summary
This PR was built on top of #5610. So waiting for it to be merged before marking this as ready to review.
References
…
Reviewer guidance
…