Update manual with PR instructions for abbreviations#684
Open
kckennylau wants to merge 2 commits intoleanprover:masterfrom
Open
Update manual with PR instructions for abbreviations#684kckennylau wants to merge 2 commits intoleanprover:masterfrom
kckennylau wants to merge 2 commits intoleanprover:masterfrom
Conversation
Added instructions for modifying abbreviation identifiers.
Contributor
|
Could you modify the text here to request discussing on Zulip first? I don't want to encourage people who don't know what they're doing to spam PRs that require Marc's review. |
Updated instructions for modifying abbreviation identifiers and added a discussion step on Zulip.
kim-em
approved these changes
Oct 27, 2025
fpvandoorn
approved these changes
Oct 27, 2025
Collaborator
|
The user manual is not the right place for instructions on the development workflow of contributing to vscode-lean4. Ideally, this guide should also document potential caveats of adding new abbreviations:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added instructions for modifying abbreviation identifiers.