Conversation
This PR fixes public declarations using autoParam section variables so their default tactics remain usable, including from importing modules. Generate exported auxiliary names with a non-private, module-specific prefix, and elaborate section variables under the visibility required by the declarations that use them. Preserve each declaration's own visibility in mixed mutual blocks. Closes #14708
github-actions
Bot
added
the
toolchain-available
This PR limits public auxiliary naming to the module-level name generator and adds coverage for helper visibility under `import all`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes public declarations using autoParam section variables so their default tactics remain usable, including from importing modules.
Outside declarations, generate exported auxiliary names with a non-private, module-specific prefix, and elaborate section variables under the visibility required by the declarations that use them. Preserve each declaration's own visibility in mixed mutual blocks.
Closes #14708