feat(LambdaCalculus): write mapVal in terms of List.map; add similar lemmas - #919
Open
pepamontero wants to merge 6 commits into
Open
pepamontero wants to merge 6 commits into
pepamontero wants to merge 6 commits into
Conversation
pepamontero
marked this pull request as ready for review
September 17, 2026 19:11
pepamontero
requested review from
arademaker,
chenson2018,
fmontesi,
kim-em and
sorrachai
as code owners
September 17, 2026 19:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a lemma
mapVal_defshowing thatmapValcan be written asList.map (Sigma.map id _).This allows for optimizing the proofs of
mapVal_keysandmapVal_memby using the properties ofList.map:map₂_keysanddlookup_map₂.Other changes:
I changed the order of
mapVal_keysto matchmap₂_keys(and then I think it can begrind =instead ofgrind .)Since
dlookup_map₂does not exactly coincide withmapVal_mem, I added an additional lemmamapVal_dlookupto match it, and then use this one to provemapVal_mem(marking it grind).Additionally, since
NodupKeys.map₂is just aftermap₂_keys, I realized a lemmamapVal_wfstating the mapping of values preserves well-formedness could be easily added as well.Depends on style(LambdaCalculus): unused variables and other small fixes in Context.lean #918