ci(nightly-testing): guard the bump-branch steps when the nightly bump branch exists - #914
Open
jessealama wants to merge 1 commit into
Open
jessealama wants to merge 1 commit into
jessealama wants to merge 1 commit into
Conversation
…p branch exists The "Exit if matching branch exists" step ran `exit 0`, which only ends that step, so the two following github-script steps ran unguarded. If no bump/v4.x.0 branch existed, the first of them threw and the `if: failure()` Zulip warning posted a misleading message about a toolchain pattern mismatch. Drop the no-op step and guard both fetch steps on the branch check, matching every later step. Post a dedicated Zulip warning when no bump/v4.x.0 branch is found, and only post the pattern-mismatch warning when the toolchain fetch step itself failed. Also replace `new Exception`, which is a ReferenceError in JavaScript, with `new Error`.
jessealama
requested review from
arademaker,
chenson2018,
fmontesi,
kim-em and
sorrachai
as code owners
September 16, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Exit if matching branch exists" step did
exit 0, which only ends that step. Since a zero exit is a success, the job simply moved on and the subsequent steps ran. When nobump/v4.x.0branch existed, the first of them threw, and theif: failure()Zulip warning could post a misleading message about a toolchain pattern mismatch, but the real reason was the non-existence of the proper branch.This PR drops the no-op step and guards both fetch steps on the branch check, as other later step already are. Post a dedicated warning to Zulip when no
bump/v4.x.0branch is found, and only post the toolchain warning when the toolchain fetch step itself failed.Also replace
new Exception, which is aReferenceErrorin JavaScript, withnew Error.Exceptiondoesn't exist in JS. So, curiously, running this code caused a different kind of exception to be thrown (aReferenceErrorfor referring to something that doesn't exist), which ended up killing the step as intended, but for the wrong reason.