feat(algorithms): add counting sort#577
Open
Robertboy18 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a formal counting sort for List ℕ (with TimeM cost model) plus shared “stability by value” utilities, and re-exports them from the root module.
Changes:
- Introduce
StableByValuepredicate for list outputs to preserve per-value subsequences. - Add
countingSortimplementation returningTimeM ℕ (List ℕ)with correctness + time complexity theorems. - Export the new modules from
Cslib.lean.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Cslib/Algorithms/Lean/Sorting.lean | Adds a reusable stability-by-value predicate for sorting utilities. |
| Cslib/Algorithms/Lean/CountingSort/CountingSort.lean | Implements counting sort in TimeM and proves correctness/time bounds. |
| Cslib.lean | Re-exports the new CountingSort and Sorting modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I also wanted to add the counting sort for
List ℕ, using an explicit upper bound on the values in the input! The key idea is that it scans the input once for each key from0through the bound, counts how many times that key occurs, and emits that many copies. The cost model counts one comparison for each inspected input element during these scans.The main correctness proof is by counts: every value appears in the output exactly as many times as it appeared in the input. From there, I just prove that sortedness, permutation correctness, stability via
StableByValue, and the exact running time in this cost model is all satisfied: )!Validation:
lake build Cslib