Bp docs restyling - #446
Conversation
…e for removed demos, updated discord and github icons to mingcute
Deploying labs-browserpod-previews with
|
| Latest commit: |
65f994b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7115803f.labs-browserpod-previews.pages.dev |
| Branch Preview URL: | https://bp-docs-restyling.labs-browserpod-previews.pages.dev |
GabrielaReyna
left a comment
There was a problem hiding this comment.
Hi Sarah!
Good job on this, some specific adjustments on the design:
- Please make the navbar blur effect stronger, I have suggested the same settings used for the browserpod site. Please test how it looks.
- Please remove the green dot animation next to the discord icon (this applies to all sites)
I am not still fully convinced on the width of the bar, specially when on big screens but I can't test it right now. We can leave this adjustment for the next iteration.
Co-authored-by: Alessandro Pignotti <alessandro@leaningtech.com>
…e for removed demos, updated discord and github icons to mingcute
…scord icon appears with an 'ineline' fix
GabrielaReyna
left a comment
There was a problem hiding this comment.
Hi Sarah
Great work with this. I am just concerned about showing the online discord members without the green dot might confused users with the total number of discord members.
I asked you to remove the green dot animation because it was resource consuming, but we have two options here:
- Keep a simple green dot next to the number of online members, but not animated.
- Remove the number of members and just keep the discord icon on its own (which matches browserpod.io)
Please try em both and go with what you think looks best.
More than that this should be ready to merge
Thank you!
|
Sorry, I didn't read your last comment correctly and understood 'remove green dot'. The animation has been removed and the star is now yellow :) |
Done:
_headerscleaned upTo Do: