Conversation
…ing $id Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RW8UxaJonYPi5cb37TgXYL
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lens.count()ignored$idin search criteria – by skippingcount()for$idqueries, callingfind()directly and returning the pre-fetched results from the paginator callback.Lens.count()to include $id in search criteria karelklima/ldkit#182 (merged 2026‑09‑26), released inldkit@2.9.0(2026‑09‑28). I verified the release tag's commit is a descendant of the#182merge commit and that the publishedcount()implementation now incorporates$idinto the count query.packages/dataset-registry-client/src/client.ts, so$idqueries go through the normalcount()/paginate path again, and raises theldkitdependency range to^2.9.0.$id” test from fix(dataset-registry-client): work around LDkit count() ignoring $id filter #207 is kept unchanged – it now exercises the upstream fix directly.Test plan
npx nx affected -t lint test typecheck build --base=origin/main– all tasks for the affected packages pass, includingdataset-registry-client’s$idtest.search-typesense,pipeline,search-pipeline) fail in this sandbox for pre‑existing, environment-specific reasons (no usable container runtime for Typesense integration tests, and a file‑permission test that behaves differently when run as root) – reproduced identically on unmodifiedmain, unrelated to this change.🤖 Generated with Claude Code
https://claude.ai/code/session_01RW8UxaJonYPi5cb37TgXYL
Generated by Claude Code