Conversation
…ink I'm right. Deprecated.
…number on the upper bound and should significantly improve numerical stability of the cpr rootfinder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to rustBCA!
Before submitting this PR, please make sure you have:
Fixes # (issue)
Description
Updates rcpr to latest version.
Deprecates root polishing - on testing with rcpr's new python interface, as far as I can tell, nothing is gained with root polishing for doca-type problems.
Implements Boyd's semi-infinite domain transformation before rootfinding (see Boyd, Solving Transcendental Equations, 2014, sections B.3 and A.5) - this restricts the rootfinding range to [0, 1] where the CPR is much better behvaved, increasing numerical stability and reducing requirements on N and epsilon.
Tests
examples/test_morse.py,cargo test, and an in-progress MD benchmark.