fix: make getting started SVGs clickable - #8030
Conversation
Signed-off-by: Aditya prakash jha <adityaprakashjha321@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughChangesClickable navigation
Priority: ⬇️ Low — Defer this navigation enhancement because it is a low-severity, user-facing update limited to clickable Getting Started integrations and platform illustrations. Estimated code review effort: 3 (Moderate) | ~20 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The clickable navigation changes are ready to merge. Sequence Diagram(s)sequenceDiagram
participant Visitor
participant NavigationComponent
participant GatsbyRouter
participant ExternalSite
Visitor->>NavigationComponent: Select logo or integration
alt Internal destination
NavigationComponent->>GatsbyRouter: Navigate with Link
else External destination
NavigationComponent->>ExternalSite: Open anchor in new tab
end
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for PR #8030 removed. This PR preview was automatically pruned because we keep only the 3 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
dhruveshmishra
left a comment
There was a problem hiding this comment.
@AdityaOP007 Please be assigned first to raise a pr, the issue is assigned to @tejaswiverma121-byte, please close your pr.
#8011
Summary
This PR fixes #8011 by making the relevant SVG illustrations on the Meshery Getting Started page clickable.
Changes
<Link>for internal navigation.Testing
git diff --checkpasses.Fixes #8011
Summary by CodeRabbit
New Features
Accessibility