Skip to content

Fix(sistent): Added Table component documentation#7737

Open
kanishksingh23 wants to merge 6 commits into
layer5io:masterfrom
kanishksingh23:fix/sistent-table-docs-v2
Open

Fix(sistent): Added Table component documentation#7737
kanishksingh23 wants to merge 6 commits into
layer5io:masterfrom
kanishksingh23:fix/sistent-table-docs-v2

Conversation

@kanishksingh23
Copy link
Copy Markdown
Contributor

@kanishksingh23 kanishksingh23 commented May 16, 2026

Description
Adds Table component documentation to the Sistent component library, including:

  • Basic Table demo
  • Sortable Table demo
  • Selectable Rows Table demo (with working checkbox selection)
  • Paginated Table demo

All demos use ResponsiveDataTable from @sistent/sistent.

This PR fixes #7607

Notes for Reviewers

  • Used useMemo for stable column/data references
  • Selectable rows wired up with rowsSelected and onRowSelectionChange
  • Added mounted state guard to fix SSR build failures
  • Generic names used in all demo data (Alice, Bob, Charlie)

This is a re-submission of PR #7692 which was closed due to git history issues
during conflict resolution. All reviewer feedback from the previous PR has been addressed.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

🚀 Preview deployment: https://layer5.io/pr-preview/pr-7737/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
@kanishksingh23 kanishksingh23 force-pushed the fix/sistent-table-docs-v2 branch from 7c757d5 to 95f770c Compare May 16, 2026 13:41
@kanishksingh23
Copy link
Copy Markdown
Contributor Author

@rishiraj38, @saurabhraghuvanshii, please have a look.

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bhumikagarggg
Copy link
Copy Markdown
Contributor

@kanishksingh23 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

…ble handle checkboxes internally

Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
@kanishksingh23 kanishksingh23 force-pushed the fix/sistent-table-docs-v2 branch from 7a88b6f to 857c6b9 Compare May 17, 2026 16:23
@kanishksingh23
Copy link
Copy Markdown
Contributor Author

Hey @rishiraj38, I have matched the implementation exactly to MesheryPatterns.tsx. But still, the checkboxes are not selectable. I think it's a Gatsby preview deployment issue.

@Rajesh-Nagarajan-11
Copy link
Copy Markdown
Member

Waiting for preview....

@kanishksingh23
Copy link
Copy Markdown
Contributor Author

Screenshot 2026-05-19 at 10 54 19 PM Screenshot 2026-05-19 at 10 54 43 PM Screenshot 2026-05-19 at 10 51 59 PM Screenshot 2026-05-19 at 10 52 22 PM

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kanishksingh23 I checked this locally as well, so it doesn’t seem to be a Gatsby deployment issue. Could you please take another look and fix it?

Screen.Recording.2026-05-20.at.9.07.42.PM.mov

…dDataAccess

Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
@kanishksingh23 kanishksingh23 force-pushed the fix/sistent-table-docs-v2 branch 2 times, most recently from 907bd5a to 5b59aa7 Compare May 20, 2026 17:49
…per pattern

Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
@kanishksingh23
Copy link
Copy Markdown
Contributor Author

kanishksingh23 commented May 20, 2026

Hey @rishiraj38

I've been thoroughly debugging the checkbox selection issue. I found React hydration errors in the browser console. I also checked the compiled @sistent/sistent bundle and confirmed ResponsiveDataTable doesn't override selectableRows. I noticed that other interactive components, like Popper, use no mount guard at all. Should I follow the same pattern for ResponsiveDataTable? Also, ResponsiveDataTable is the only usage of this component in the entire Layer5 repo, so there's no existing pattern to reference. Could you share a minimal working example of SelectableTableDemo with selectableRows: "multiple" that works locally?

Also, I am currently in my end semester exams, so my responses might be a bit slow. I will get back to this as soon as I can.

…uard

Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
@kanishksingh23 kanishksingh23 force-pushed the fix/sistent-table-docs-v2 branch from 4b33b97 to 5ee34ca Compare May 20, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sistent] Add Table component to the Sistent components page

4 participants