Fix(sistent): Added Table component documentation#7737
Conversation
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
|
🚀 Preview deployment: https://layer5.io/pr-preview/pr-7737/
|
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
7c757d5 to
95f770c
Compare
|
@rishiraj38, @saurabhraghuvanshii, please have a look. |
There was a problem hiding this comment.
Selectable table component is not working. Please take reference from:
UI reference:
https://playground.meshery.io/configuration/designs?view=table
Code reference:
https://github.com/meshery/meshery/blob/master/ui/components/designs/patterns/MesheryPatterns.tsx#L532
|
@kanishksingh23 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
…ble handle checkboxes internally Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
7a88b6f to
857c6b9
Compare
|
Hey @rishiraj38, I have matched the implementation exactly to MesheryPatterns.tsx. But still, the checkboxes are not selectable. I think it's a Gatsby preview deployment issue. |
|
Waiting for preview.... |
rishiraj38
left a comment
There was a problem hiding this comment.
@kanishksingh23 I checked this locally as well, so it doesn’t seem to be a Gatsby deployment issue. Could you please take another look and fix it?
Screen.Recording.2026-05-20.at.9.07.42.PM.mov
…dDataAccess Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
907bd5a to
5b59aa7
Compare
…per pattern Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
|
Hey @rishiraj38 I've been thoroughly debugging the checkbox selection issue. I found React hydration errors in the browser console. I also checked the compiled @sistent/sistent bundle and confirmed ResponsiveDataTable doesn't override selectableRows. I noticed that other interactive components, like Popper, use no mount guard at all. Should I follow the same pattern for ResponsiveDataTable? Also, ResponsiveDataTable is the only usage of this component in the entire Layer5 repo, so there's no existing pattern to reference. Could you share a minimal working example of SelectableTableDemo with selectableRows: "multiple" that works locally? Also, I am currently in my end semester exams, so my responses might be a bit slow. I will get back to this as soon as I can. |
…uard Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
4b33b97 to
5ee34ca
Compare




Description
Adds Table component documentation to the Sistent component library, including:
All demos use
ResponsiveDataTablefrom@sistent/sistent.This PR fixes #7607
Notes for Reviewers
useMemofor stable column/data referencesrowsSelectedandonRowSelectionChangemountedstate guard to fix SSR build failuresSigned commits