feat: Add 'source_url' to news articles for original source attributi…#7228
feat: Add 'source_url' to news articles for original source attributi…#7228leecalcote merged 13 commits intolayer5io:masterfrom
Conversation
|
🚀 Preview for commit a49201e at: https://6934720953d25512b3111772--layer5.netlify.app |
|
@leecalcote , please review and give some feedback. |
leecalcote
left a comment
There was a problem hiding this comment.
@rishiraj38, thank you. Will you please:
- Confirm that the optional aspect of this property is supported?
- For each published item in our news collection, add its source_url, if one is included (most should have one).
|
This is looking real good otherwise, @rishiraj38 👍 |
|
@leecalcote Yes, |
|
🚀 Preview for commit c9fc75e at: https://6935782cc211bb3da70ebb7b--layer5.netlify.app |
|
@rishiraj38 Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 8 AM CT Add it as an agenda item to the meeting minutes, if you would 🙂 |
leecalcote
left a comment
There was a problem hiding this comment.
@rishiraj38, send word when you have updated each item in the news collection with their respective source_url.
2d4b0b7 to
a3362c7
Compare
|
🚀 Preview for commit b73e5c2 at: https://69367db053d25577e31116d2--layer5.netlify.app |
|
@leecalcote ,please provide some feedback. |
|
@rishiraj38 |
|
🚀 Preview for commit cd38790 at: https://69370aec4fa46d596b5f4da7--layer5.netlify.app |
Best that you describe what changes you've made, so that I'm aware of what, specifically, you're looking for feedback on, @rishiraj38 |
| thumbnail: "./what-the-numbers-say-about-how-service-meshes-are-used-today.webp" | ||
| darkthumbnail: "./what-the-numbers-say-about-how-service-meshes-are-used-today.webp" | ||
| eurl: https://thenewstack.io/what-the-numbers-say-about-how-service-meshes-are-used-today/ | ||
| source_url: https://thenewstack.io/what-the-numbers-say-about-how-service-meshes-are-used-today/ |
| thumbnail: ./service-mesh-implementations.webp | ||
| darkthumbnail: ./service-mesh-implementations.webp | ||
| eurl: https://thenewstack.io/kubeconcloudnativecon-service-mesh-battle-stories-and-fixes/ | ||
| source_url: https://thenewstack.io/kubeconcloudnativecon-service-mesh-battle-stories-and-fixes/ |
4b896a9 to
f68b8c0
Compare
|
@Rajesh-Nagarajan-11 I don’t know what’s happening. The DCO is failing yet I’m making signed commits. |
456afbf to
d614286
Compare
|
🚀 Preview for commit d614286 at: https://6937b4db9fe43cdf8c1e89c6--layer5.netlify.app |
|
@leecalcote , I’ve added the source URL to the news article that contained an eurl. Now, what do I do with the news articles that don’t have eurl? |
|
🚀 Preview for commit 61d2ec8 at: https://694a380a8f2f9c9997ca5958--layer5.netlify.app |
|
@leecalcote @ritesh-karankal Could you please provide feedback on the latest build and let me know if any further changes are needed? |
|
The Learn More link should not be about the author. It is just a link to read the original article. @rishiraj38 my confidence wanes that you’ll get this done. It’s taken too much time, and too much back and forth on what is a straight-forward concept. Let’s get this wrapped up pronto. |
Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
|
🚀 Preview for commit 9ae26bd at: https://694d2957329c8e9f426fbe31--layer5.netlify.app |
|
🚀 Preview for commit f0d4259 at: https://695281ed1d20c7bf1ae6c771--layer5.netlify.app |
|
@leecalcote @ritesh-karankal Done with the Changes . |
|
🚀 Preview for commit 17dcc52 at: https://6954b02b75be479b53f37108--layer5.netlify.app |
@rishiraj38, are you sure this time? |
|
🚀 Preview for commit d9d0fac at: https://6963b3c498dfcd82c3c205ec--layer5.netlify.app |
|
@rishiraj38 |
|
🚀 Preview for commit e330517 at: https://696e49e9ef3a3a260f4a1ab6--layer5.netlify.app |
|
@ritesh-karankal , this issue has been open for a while and I’ve made the changes. Please review and provide some feedback. |
|
🚀 Preview for commit 07e585f at: https://696f912a516ce970c23b711f--layer5.netlify.app |
|
How many months does it take.... aargh, @rishiraj38. 🤪 |
|
We have new news that now needs to be updated to account for this change, @rishiraj38 @jeetburman #7367 |

Description
This PR adds an optional
source_urlfield to the news article data model. This allows reprinted news articles to properly attribute and link back to the original source.Changes included:
source_urlfrom frontmatter.This fixes #7135.
Requirements
Suggested tasks
Acceptance criteria
Notes for Reviewers
You can verify this by checking any news article that has the
source_urlfield added to its frontmatter (none are added in this PR to keep it valid for existing content, but the template is updated for future use).Signed commits