feat: popup also in kanvas page#6923
Conversation
|
🚀 Preview for commit 1e7a0b5 at: https://68d9586ea331b3f124ca6f80--layer5.netlify.app |
|
🚀 Preview for commit 70adf95 at: https://68d95c1b6334ac0f6c10076f--layer5.netlify.app |
|
Thanks for the feedback @Rajesh-Nagarajan-11 |
|
🚀 Preview for commit 9d5a109 at: https://68d989976b775291163e050b--layer5.netlify.app |
|
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
|
@Fireentity Im not sure about that , did you got insights from website meeting ? |
|
@Rajesh-Nagarajan-11 |
|
@Fireentity Could you please share what help you wanted , let me try to help you if possible |
|
@Rajesh-Nagarajan-11 |
|
In this page https://layer5.io/cloud-native-management/kanvas/collaborate you can find a animated image If possible you can create a pop with same animated one that will looks perfect |
|
https://layer5.io/company/brand here you can get some brand template that might helpful to build popup |
|
🚀 Preview for commit de63184 at: https://68de962fbaee359c4319e9a8--layer5.netlify.app |
There was a problem hiding this comment.
@Fireentity Really looks good please increase bit height ( very bit ) of popup will be super clean
|
🚀 Preview for commit 537b953 at: https://68e10f88e7ed381c74dacf78--layer5.netlify.app |
|
@leecalcote He implemented in kanvas page |
The image might need an update, so it looks consistent with the pop on landing page , @leecalcote can you help with a new image for kanvas pop up or is the current one good enough. |
|
@Namanv0509 |
|
@Namanv0509 Thanks for the feedback. As we discussed in our last call, I'll work on making the style consistent with the homepage popup as soon as possible. |
|
@Fireentity Any updates ? please resolve merge conflicts |
|
@Rajesh-Nagarajan-11 |
Signed-off-by: Lorenzo Croce <lorenzo.croce@arenastudios.it>
Signed-off-by: Lorenzo Croce <lorenzo.croce@arenastudios.it>
Signed-off-by: Lorenzo Croce <lorenzo.croce@arenastudios.it>
Signed-off-by: Lorenzo Croce <lorenzo.croce@arenastudios.it>
0296d2c to
d9a772b
Compare
|
🚀 Preview for commit d9a772b at: https://68fd2e1fd4cc7239d71a2a42--layer5.netlify.app |
| // const SoSpecial = loadable(() => import("../sections/Home/So-Special-Section")); | ||
| const MesheryIntegration = loadable(() => import("../sections/Meshery/Meshery-integrations")); | ||
| const FeaturesContainer = loadable(() => import("../sections/Home/FeaturesContainer")); | ||
| import popupImageSmall from "../sections/Home/CornerPopup/power-of-meshery-small.png"; |
There was a problem hiding this comment.
use .webp remove .png for consistency
|
@Fireentity Any updates ? |
|
@Rajesh-Nagarajan-11, I reached out to @Namanv0509 because I was unable to locate the popup background in the Layer5 Figma file. |
|
🚀 Preview for commit 326ea72 at: https://691588f3f813a26dfb215bd3--layer5.netlify.app |
Signed-off-by: Lee Calcote <leecalcote@gmail.com>
|
Merge conflicts resolved. |
|
PR has been resync'ed with |
|
🚀 Preview for commit 508f657 at: https://692d49b4556ae79f7c645e18--layer5.netlify.app |
the X icon is missing in pop up and also please fix the eslint error aswell @Fireentity
|
|
🚀 Preview for commit 896300c at: https://69345077c7d983db67ae8a31--layer5.netlify.app |
|
🚀 Preview for commit 0624a20 at: https://69521efbe05f92b69dd1b242--layer5.netlify.app |
|
@Fireentity are you still working on this? |
|
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
1 similar comment
|
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
|
🚀 Preview for commit 7b062b0 at: https://695de59d79426669cd1e9a38--layer5.netlify.app |
|
Closing this PR due to inactivity. |






Description
This PR fixes #6444
Notes for Reviewers
Signed commits