feat: Add the FDv2 data system orchestrator - #190
Open
beekld wants to merge 7 commits into
Open
Conversation
beekld
force-pushed
the
bklimt/SDK-2753/fdv2-orchestrator
branch
from
August 10, 2026 18:41
4ea2eb8 to
775e611
Compare
beekld
force-pushed
the
bklimt/SDK-2753/fdv2-orchestrator
branch
from
August 10, 2026 18:46
775e611 to
2fa17de
Compare
beekld
force-pushed
the
bklimt/SDK-2753/fdv2-orchestrator
branch
from
August 12, 2026 21:45
2fa17de to
a523fa8
Compare
beekld
force-pushed
the
bklimt/SDK-2753/fdv2-orchestrator
branch
from
August 12, 2026 22:10
a523fa8 to
3e77e84
Compare
beekld
force-pushed
the
bklimt/SDK-2753/fdv2-orchestrator
branch
from
August 13, 2026 21:29
3e77e84 to
f3e5a99
Compare
beekld
marked this pull request as ready for review
August 13, 2026 21:35
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f3e5a99. Configure here.
| // Good data clears the fallback countdown. | ||
| fallback_at = None; | ||
| interrupted_logged = false; | ||
| } |
There was a problem hiding this comment.
None changesets treated as real updates
High Severity
Any ChangeSet is treated as a basis, including ChangeSetKind::None from polling 304 and xfer-none. Those payloads carry a None selector, so the live basis is overwritten and init_complete(true) can fire with an empty store. Later next calls then omit basis, forcing full transfers instead of deltas.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit f3e5a99. Configure here.
…they are consumed
beekld
force-pushed
the
bklimt/SDK-2753/fdv2-orchestrator
branch
from
August 14, 2026 20:53
f3e5a99 to
58c2a46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Adds the FDv2 orchestrator, the
DataSystemimplementation that owns thein-memory store and keeps it populated. It runs an initializer phase to obtain
a basis, then a synchronizer phase for ongoing changes.
The initializer phase tries each initializer in order until one produces a
basis. The synchronizer phase then runs one synchronizer at a time and rotates
between them on three triggers:
interruption.
interval.
Initialization is signaled as complete on the first basis and as failed once
every source is exhausted without one, because the client's initialization path
already resolves to success or failure. Synchronizer status transitions are
logged, with interruptions at info (not repeated while ongoing) and terminal
errors at warn.
Note
Overview
Introduces
FDv2DataSystem, the FDv2DataSystemthat owns an in-memory store and keeps it updated through initializer and synchronizer phases.Initializer phase walks configured initializers until one returns a full basis (
ChangeSet), applies it viaTransactionalDataStore::apply, and signalsinit_complete(true)once.Synchronizer phase runs one synchronizer at a time, passing the latest selector into
next, and applies partial/full change sets as they arrive.SourceManagerrotates among synchronizer factories: sustained interruption arms a fallback timer to advance to the next source; a recovery timer (when not on the prime) rewinds to the primary; terminal errors block that factory and move on. Shutdown ends the loop without a failure callback if init never completed.Registers the module in
fdv2/mod.rsand removes staledead_codeallowances onChangeSet.selectorandTransactionalDataStorenow that the orchestrator consumes them. Adds broad unit/integration-style tests for rotation, timers, init signaling, and store reads.Reviewed by Cursor Bugbot for commit 58c2a46. Bugbot is set up for automated code reviews on this repo. Configure here.