fix: Report slash- and tilde-prefixed redacted attributes as escaped references - #56
Draft
beekld wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a context has a custom attribute whose literal name begins with
/, the redaction logic that builds an event's_meta.redactedAttributesfailed to list it.The serializer converted each literal attribute name to a
ReferenceviaReference::new(key), which interprets a leading/as attribute-pointer syntax. For an attribute literally named/ssn, that parsed to the pointer componentssn, so the value lookup found nothing and the attribute was silently dropped fromredactedAttributes. The value itself was never emitted, so there was no data leak. The attribute was just never reported.This builds the reference from the literal name using the ATREF backwards-compatibility escaping (
~->~0,/->~1, prepend/), so/ssnis now reported as/~1ssn.This fix is needed for the rust-server-sdk to pass the v3 contract tests.