Repository navigation
fix: Prevent the DynamoDB store from failing when flags or segments exceed 1 MB - #464
Merged
Merged
Conversation
jsonbailey
marked this pull request as ready for review
October 9, 2026 16:07
joker23
approved these changes
Oct 9, 2026
kinyoklion
approved these changes
Oct 9, 2026
jsonbailey
pushed a commit
that referenced
this pull request
Oct 9, 2026
🤖 I have created a release *beep* *boop* --- ## [8.18.3](8.18.2...8.18.3) (2026-10-09) ### Bug Fixes * Prevent the DynamoDB store from failing when flags or segments exceed 1 MB ([#464](#464)) ([3777ee1](3777ee1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > **Release 8.18.3** — bumps the SDK from `8.18.2` to `8.18.3` across the release manifest, `LaunchDarkly::VERSION`, and the provenance verification example in `PROVENANCE.md`. > > `CHANGELOG.md` documents the shipped fix: the DynamoDB persistent feature store no longer fails when individual flags or segments exceed DynamoDB’s 1 MB item limit ([#464](#464)). This PR is Release Please metadata only; the implementation landed in an earlier commit. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 9977ae3. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DynamoDB feature store raised
NoMethodError: undefined method 'exclusive_start_key=' for an instance of Hashwhen a Query for one kind needed a second page. DynamoDB returns at most 1 MB per page, so this happened once all flags or all segments together exceeded about 1 MB.initfailed on every stream connect, so the persistent store never updated. The bug has been present since the DynamoDB store was added in 5.5.0.get_all_internalandread_existing_keys).limit, so the real server pages a small data set. The tests check that more than one page is read inalland ininit.Verified against aws-sdk-dynamodb 1.174.0, and 1.57.0 (the gemspec floor) with aws-sdk-core 3.109.0 (its floor).
Closes #462
Note
Overview
Fixes DynamoDB feature store pagination when a Query returns more than one page (~1 MB of flags/segments). Paging loops now set
req[:exclusive_start_key]on the request Hash instead of callingexclusive_start_key=, which raisedNoMethodErrorand brokeallandiniton the second page.The spec table-clear scan loop uses the same Hash-key fix. New DynamoDB Local tests inject a small Query
limitso multi-page reads are exercised foralland forinit(including deletion of keys dropped from the new payload).Reviewed by Cursor Bugbot for commit b2b0d6f. Bugbot is set up for automated code reviews on this repo. Configure here.