feat: Support additional create methods for agent and agent_graph#102
Open
jsonbailey wants to merge 2 commits intojb/aic-1664/uv-conversionfrom
Open
feat: Support additional create methods for agent and agent_graph#102jsonbailey wants to merge 2 commits intojb/aic-1664/uv-conversionfrom
jsonbailey wants to merge 2 commits intojb/aic-1664/uv-conversionfrom
Conversation
fix!: Rename default_ai_provider parameter → default_connector on all LDAIClient methods feat!: Rename AIProvider → AIConnector feat!: Rename AIProviderFactory → RunnerFactory, create_model/agent/agent_graph() feat!: Rename OpenAIProvider → OpenAIConnector feat!: Rename LangChainProvider → LangChainConnector
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix!: Rename default_ai_provider parameter → default_connector on all LDAIClient methods
feat!: Rename AIProvider → AIConnector
feat!: Rename AIProviderFactory → RunnerFactory, create_model/agent/agent_graph()
feat!: Rename OpenAIProvider → OpenAIConnector
feat!: Rename LangChainProvider → LangChainConnector
Note
Medium Risk
Broad rename/refactor across the SDK and provider packages (interfaces, factories, and public method parameters) introduces breaking API changes and could impact runtime backend selection. Behavior is mostly preserved, but new connector instantiation defaults (e.g., OpenAI client from env) and fallback creation paths increase integration risk.
Overview
Refactors the SDK/provider integration from
AIProviderto a new per-backendAIConnectorabstraction. This renamesAIProvider/AIProviderFactorytoAIConnector/RunnerFactory, updatesChat/Judge/LDAIClientto depend on connectors, and changes the public override parameter fromdefault_ai_providertodefault_connector.Adds a new
RunnerFactorycapability factory that can createmodel,agent, andagent_graphrunners with a shared fallback mechanism across backends.Updates backend packages to match the new connector model.
OpenAIProvider/LangChainProviderbecomeOpenAIConnector/LangChainConnector, adoptingcreate_model()instance factories; OpenAI now lazily builds anAsyncOpenAIclient fromOPENAI_API_KEYwhen not provided. Tests are updated accordingly and legacy provider/factory files are removed.Written by Cursor Bugbot for commit dd194a8. This will update automatically on new commits. Configure here.