Skip to content

fix: Unsubscribe the provider's listeners on shutdown #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinyoklion merged 3 commits into from
Oct 2, 2026
Merged

fix: Unsubscribe the provider's listeners on shutdown #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2f07de
fix: Do not emit duplicate provider events
devin-ai-integration[bot] Sep 2, 2026
65712ed
fix: Emit provider events after a failed initialization
devin-ai-integration[bot] Sep 29, 2026
97aca8a
Merge remote-tracking branch 'origin/devin/1788360613-ruby-zero-start…
devin-ai-integration[bot] Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/ldclient-openfeature/provider.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,11 @@ def initialize(sdk_key, config = LaunchDarkly::Config.default, wait_for_seconds

@metadata = ::OpenFeature::SDK::Provider::ProviderMetadata.new(name: "launchdarkly-openfeature-server").freeze

@client.data_source_status_provider.add_listener(Impl::DataSourceStatusListener.new(self))
@client.flag_tracker.add_listener(Impl::FlagChangeListener.new(self))
@status_listener = Impl::DataSourceStatusListener.new(self)
@flag_change_listener = Impl::FlagChangeListener.new(self)

@client.data_source_status_provider.add_listener(@status_listener)
@client.flag_tracker.add_listener(@flag_change_listener)
end

#
Expand Down Expand Up @@ -116,6 +119,8 @@ def emit_status_event(event, **details)
# @return [void]
#
def shutdown
@client.data_source_status_provider.remove_listener(@status_listener)
@client.flag_tracker.remove_listener(@flag_change_listener)
@client.close
end

Expand Down
8 changes: 6 additions & 2 deletions spec/provider_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,15 @@ def data_source_status(state, error = nil)
.with(OpenFeature::SDK::ProviderEvent::PROVIDER_STALE, hash_including(:message))
end

it "shutdown closes the client" do
allow(provider.client).to receive(:close)
it "shutdown unsubscribes the listeners and closes the client" do
status_provider = double(remove_listener: nil)
flag_tracker = double(remove_listener: nil)
allow(provider.client).to receive_messages(close: nil, data_source_status_provider: status_provider, flag_tracker: flag_tracker)

provider.shutdown

expect(status_provider).to have_received(:remove_listener).with(instance_of(LaunchDarkly::OpenFeature::Impl::DataSourceStatusListener))
expect(flag_tracker).to have_received(:remove_listener).with(instance_of(LaunchDarkly::OpenFeature::Impl::FlagChangeListener))
expect(provider.client).to have_received(:close)
end

Expand Down
Loading