feat: Report provider name and version to LaunchDarkly - #30
Draft
kinyoklion wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reports the provider as the wrapper so LaunchDarkly can attribute usage to the OpenFeature Ruby provider rather than the base Ruby SDK.
Config#with_wrapper_information("open-feature-ruby-server", VERSION), leaving the application's configuration untouched.launchdarkly-server-sdk >= 8.15.0, which is the release that addsConfig#with_wrapper_information(feat: Add Config#with_wrapper_information ruby-server-sdk#421). CI here will fail to resolve dependencies until that version is published.Implementation details
Requirements
Related issues
Part of an audit of the LaunchDarkly OpenFeature providers against the current OpenFeature specification. The Java and .NET providers already identify themselves via wrapper info; the Ruby provider did not, so usage of this provider was indistinguishable from direct use of the Ruby server SDK.
Describe the solution you've provided
Configis immutable and exposeswrapper_name/wrapper_versionas readers only, so the base SDK gained a supported way to derive a configuration with different wrapper information. The provider calls it when constructing its client.Describe alternatives you've considered
Setting the configuration's instance variables from the provider — rejected, as the provider must not depend on SDK internals. Rebuilding the configuration from its public readers — rejected because it would silently drop configuration options the provider does not know about.
Testing
bundle exec rake(RSpec + RuboCop) on Ruby 3.4, with the base SDK resolved from a local checkout of launchdarkly/ruby-server-sdk#421: 55 examples, 0 failures; 12 files inspected, no offenses.Sequencing
This PR must not be merged before
launchdarkly-server-sdk8.15.0 is released; until then dependency resolution fails in CI.@cursor review
Link to Devin session: https://app.devin.ai/sessions/0c452d209ec54b068ba120b4c92b8f6c
Requested by: @kinyoklion