Skip to content

fix: Include an error type in provider error events #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kinyoklion wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Include an error type in provider error events #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/LaunchDarkly.OpenFeature.ServerProvider/Provider.StatusProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ private void EmitProviderEvent(ProviderEventTypes type, string message)
payload.Message = message;
}

if (type == ProviderEventTypes.ProviderError)
{
payload.ErrorType = ErrorType.General;
}

// Trigger the task do run, but don't wait for it. We wrap the exceptions inside SafeWrite,
// so we aren't going to have unexpected exceptions here.
Task.Run(() => SafeWrite(payload)).ConfigureAwait(false);
Expand Down
31 changes: 31 additions & 0 deletions test/LaunchDarkly.OpenFeature.ServerProvider.Tests/ProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using LaunchDarkly.Sdk.Server;
using LaunchDarkly.Sdk.Server.Interfaces;
using Moq;
using OpenFeature.Constant;
using OpenFeature.Model;
using Xunit;
using LaunchDarkly.Sdk.Server.Integrations;
Expand Down Expand Up @@ -273,6 +274,36 @@ public async Task ItEmitsConfigurationChangedEvents()
Assert.NotEqual(eventPayloadA?.FlagsChanged[0], eventPayloadB?.FlagsChanged[0]);
}

[Fact(Timeout = 5000)]
public async Task ItIncludesAnErrorTypeInErrorEvents()
{
var mockClient = new Mock<ILdClient>();
mockClient.Setup(l => l.GetLogger())
.Returns(Components.NoLogging.Build(null).LogAdapter.Logger(null));
mockClient.Setup(l => l.Initialized).Returns(true);

var mockDataSourceStatus = new Mock<IDataSourceStatusProvider>();
mockDataSourceStatus.Setup(l => l.Status).Returns(new DataSourceStatus
{
State = DataSourceState.Valid
});
mockClient.Setup(l => l.DataSourceStatusProvider).Returns(mockDataSourceStatus.Object);

var mockFlagTracker = new Mock<IFlagTracker>();
mockClient.Setup(l => l.FlagTracker).Returns(mockFlagTracker.Object);

var provider = new Provider(mockClient.Object);
await provider.InitializeAsync(EvaluationContext.Empty);

mockDataSourceStatus.Raise(e => e.StatusChanged += null,
mockDataSourceStatus.Object,
new DataSourceStatus { State = DataSourceState.Off });

var errorEvent = await provider.GetEventChannel().Reader.ReadAsync() as ProviderEventPayload;
Assert.Equal(ProviderEventTypes.ProviderError, errorEvent?.Type);
Assert.Equal(ErrorType.General, errorEvent?.ErrorType);
}

[Fact(Timeout = 5000)]
public void ItTracksCustomEvents()
{
Expand Down
Loading