Skip to content

chore: Update Skip Howdy example - #733

Open
abelonogov-ld wants to merge 7 commits into
mainfrom
andrey/howdy-deduper-final
Open

chore: Update Skip Howdy example#733
abelonogov-ld wants to merge 7 commits into
mainfrom
andrey/howdy-deduper-final

Conversation

@abelonogov-ld

@abelonogov-ld abelonogov-ld commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Update Skip Howdy example


Note

Overview
Updates the skipapp-howdy e2e sample to newer LaunchDarkly mobile SDKs (iOS 11.5.0, Android 5.15.0) in Package.swift, skip.yml, and docs.

iOS package resolution no longer uses LD_SWIFT_OBSERVABILITY_PATH or a home-directory default; swift-launchdarkly-observability is resolved as a sibling checkout and turned into an absolute path via #filePath so Skip’s copied manifest still works on Android.

Adds BuildInfo to show a “Compiled …” timestamp on the Welcome screen (executable mod date on iOS, package lastUpdateTime on Android) and splits OpenTelemetry service.name into observability-skip-ios vs observability-skip-android so platform builds are separable in LaunchDarkly. Comments and localization entries align with the existing Flags/Observe demo controls (e.g. deduped flag_exposure, Evaluate twice, Track app-error, Identify new context).

Reviewed by Cursor Bugbot for commit 3c897a6. Bugbot is set up for automated code reviews on this repo. Configure here.

abelonogov-ld and others added 3 commits August 14, 2026 16:16
…re hook

The import was left behind after removing a temporary beforeIdentify override
that was only used to confirm DedupingHook still resets on identify.

Co-authored-by: Cursor <cursoragent@cursor.com>
@abelonogov-ld
abelonogov-ld requested a review from a team as a code owner August 14, 2026 23:27
* main:
  chore: release main (#741)
  feat(react-native): fix lagging masks and imageQuality option (#734)
  chore: release main (#736)
  fix(android): anchor session replay masks to the rendered frame and cover stretch overscroll (Rubber animation) (#739)
  fix: remediate dependency vulnerabilities across npm, go, pip, and rubygems (#732)
  chore: release main (#735)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 77532ca. Configure here.

let observabilityPath = URL(fileURLWithPath: #filePath)
.deletingLastPathComponent()
.appendingPathComponent("../../../swift-launchdarkly-observability")
.standardized.path

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observability path breaks after Skip copy

High Severity

The observability checkout is resolved from #filePath, which is re-evaluated wherever Skip copies this manifest. That copy lives under the plugin output directory, so the sibling path no longer points at swift-launchdarkly-observability. The previous home-directory and LD_SWIFT_OBSERVABILITY_PATH lookup stayed valid after that copy; this one does not, so Android package resolution can fail.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 77532ca. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants