refactor: make dev-server, login, and sourcemaps commands testable via CallCmd()#654
Open
refactor: make dev-server, login, and sourcemaps commands testable via CallCmd()#654
Conversation
…ia CallCmd() Wire NewStartServerCmd, NewLoginCmd, and NewSourcemapsCmd through the existing APIClients struct instead of constructing hardcoded real clients inline. Add dev_server.MockClient and three tests for start_server.go.
apucacao
approved these changes
Mar 10, 2026
cspath1
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Describe the solution you've provided
Wire NewStartServerCmd, NewLoginCmd, and NewSourcemapsCmd through the existing APIClients struct instead of constructing hardcoded real clients inline. Add dev_server.MockClient and three tests for start_server.go.
This is the first step in a larger effort to improve test coverage in this repo.
Note
Low Risk
Primarily dependency-injection and new unit tests; runtime behavior should be unchanged aside from how clients are constructed and passed in.
Overview
Refactors CLI wiring so
login,dev-server, andsourcemapscommands use clients provided viacmd.APIClientsrather than constructing realresources/dev_serverclients inline, making these commands testable throughcmd.CallCmd().Adds a
dev_server.MockClientand newdev-server starttests that assert--contextand--overrideJSON are parsed and forwarded toRunServer, and that malformed context JSON returns an error without starting the server.Written by Cursor Bugbot for commit 3e96fcd. This will update automatically on new commits. Configure here.