Skip to content

build: upgrade to typescript 6#1424

Draft
joker23 wants to merge 3 commits into
mainfrom
skz/sdk-2193/typescript-6
Draft

build: upgrade to typescript 6#1424
joker23 wants to merge 3 commits into
mainfrom
skz/sdk-2193/typescript-6

Conversation

@joker23

@joker23 joker23 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

This PR will update all of the configuration files (package.json, jest.config.js, and tsconfig.json) to use typescript 6.

There shouldn't be any implementation changes here as all implementation at this point should conform nicely with the new typescript version.


Note

Medium Risk
Wide toolchain change across every package can alter emitted declarations, module resolution, and CI check/build behavior even without application code edits; verify full monorepo build and tests.

Overview
Upgrades the monorepo from TypeScript 5.1.6 to 6.0.3 across the root and workspace packages, with matching updates to Jest/ts-jest and tsconfig settings so tsc, tests, and bundlers still work under TS 6.

Compiler config is adjusted for TS 6 defaults and stricter resolution: moduleResolution moves from legacy node to bundler (most browser/edge/tsup packages) or node16 (Node CJS packages like server-node, stores, and several examples). Several packages switch module from commonjs to ESNext or node16, bump lib toward es2020, and add ignoreDeprecations: "6.0" where needed. Explicit types for Jest/Node are added in many tsconfigs.

Jest: root jest.config.js configures ts-jest with module: 'CommonJS' for tests. Package jest configs are mostly reformatted; React-related jest ts-jest options are simplified.

Build tooling: React SDK adds tsconfig.build.json (extends main config with deprecation ignores) and points tsup at it for DTS generation. Shopify Oxygen contract-tests set tsup dts: false. Server-AI example tsconfigs gain rootDir/outDir and bundler resolution. The hello-react example bumps @types/react / @types/react-dom to v19.

Reviewed by Cursor Bugbot for commit 462a5a2. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179579 bytes
Compressed size limit: 200000
Uncompressed size: 831422 bytes

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31978 bytes
Compressed size limit: 34000
Uncompressed size: 114243 bytes

@joker23 joker23 force-pushed the skz/sdk-2193/typescript-6 branch from 5a372d8 to afad83f Compare June 9, 2026 14:09
@joker23 joker23 force-pushed the skz/sdk-2193/typescript-6 branch 2 times, most recently from 7cdd3b4 to 85454a3 Compare June 23, 2026 16:55
@joker23 joker23 force-pushed the skz/sdk-2193/typescript-6 branch from 85454a3 to 6e50860 Compare June 24, 2026 16:18
@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38756 bytes
Compressed size limit: 39000
Uncompressed size: 212356 bytes

@joker23

joker23 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 462a5a2. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant