Open
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
b6e0f3c to
47c81cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
sdk-1910
Describe the solution you've provided
added the test
Additional context
I deviated a bit from the specs and read the flag value from the UI. I think we should update the specs to include this as a way to verify.
Note
Medium Risk
Adds new Playwright-based e2e execution to CI (including a new nightly workflow) and changes example env var expectations, which could cause CI failures or scheduled runs to break if secrets/roles or placeholders don’t match.
Overview
Adds a Playwright e2e smoke test for
@launchdarkly/browser-example(with newplaywright.config.ts,e2e/verify.spec.ts, andyarn testscript/deps) that verifies the page reports the flag evaluates totrue.Updates the example’s configuration to use
LAUNCHDARKLY_CLIENT_SIDE_ID/LAUNCHDARKLY_FLAG_KEYin.env.template, README, andtsdown.config.tsplaceholder replacement.Extends GitHub Actions to run the browser example test as part of
browser.ymland introduces a new scheduledbrowser-nightly.yamlworkflow that runs the same example job daily (including installing Chromium via Playwright).Written by Cursor Bugbot for commit f21bfcb. This will update automatically on new commits. Configure here.