Skip to content

test(js-client-sdk): adding hello app test#1158

Open
joker23 wants to merge 4 commits intomainfrom
skz/sdk-1910/browser-example-test
Open

test(js-client-sdk): adding hello app test#1158
joker23 wants to merge 4 commits intomainfrom
skz/sdk-1910/browser-example-test

Conversation

@joker23
Copy link
Contributor

@joker23 joker23 commented Mar 5, 2026

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

sdk-1910

Describe the solution you've provided

added the test

Additional context

I deviated a bit from the specs and read the flag value from the UI. I think we should update the specs to include this as a way to verify.


Open with Devin

Note

Medium Risk
Adds new Playwright-based e2e execution to CI (including a new nightly workflow) and changes example env var expectations, which could cause CI failures or scheduled runs to break if secrets/roles or placeholders don’t match.

Overview
Adds a Playwright e2e smoke test for @launchdarkly/browser-example (with new playwright.config.ts, e2e/verify.spec.ts, and yarn test script/deps) that verifies the page reports the flag evaluates to true.

Updates the example’s configuration to use LAUNCHDARKLY_CLIENT_SIDE_ID/LAUNCHDARKLY_FLAG_KEY in .env.template, README, and tsdown.config.ts placeholder replacement.

Extends GitHub Actions to run the browser example test as part of browser.yml and introduces a new scheduled browser-nightly.yaml workflow that runs the same example job daily (including installing Chromium via Playwright).

Written by Cursor Bugbot for commit f21bfcb. This will update automatically on new commits. Configure here.

@joker23 joker23 requested a review from a team as a code owner March 5, 2026 18:28
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25566 bytes
Compressed size limit: 26000
Uncompressed size: 125383 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 172130 bytes
Compressed size limit: 200000
Uncompressed size: 800872 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 24212 bytes
Compressed size limit: 25000
Uncompressed size: 83755 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 21281 bytes
Compressed size limit: 24000
Uncompressed size: 110213 bytes

devin-ai-integration[bot]

This comment was marked as resolved.

cursor[bot]

This comment was marked as resolved.

@joker23 joker23 force-pushed the skz/sdk-1910/browser-example-test branch from b6e0f3c to 47c81cb Compare March 10, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant