chore: float logger constraint within its current major - #32
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
|
@cursor review |
keelerm84
approved these changes
Sep 21, 2026
tanderson-ld
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widens the only Gemfile constraint that was locked to a single minor series so it floats within its current major, keeping today's version as the floor.
gem 'logger', '~> 1.7.0'→'~> 1.7'(>= 1.7.0, < 2.0); resolution is unchanged today (1.7.0 is latest).launchdarkly-server-sdk '~> 8.0'left as-is — it already floats within 8.x and resolves to the latest 8.18.0.observer '~> 0.1.0'andbenchmark '~> 0.5.0'left as-is — 0.x minors are breaking, so they are not widened.main.rb; no README or CI changes needed.Implementation details
Versions resolved (Ruby 3.4.10 via mise, bundler 2.7.2,
Gemfile.lockis gitignored sobundle installalways resolves fresh):launchdarkly-server-sdk 8.18.0 (latest), logger 1.7.0 (latest), benchmark 0.5.0 (latest), observer 0.1.2, plus transitive concurrent-ruby 1.3.8, http 6.0.4, ld-eventsource 2.6.0, json 3.0.2, openssl 4.0.2.
Testing performed
bundle _2.7.2_ installbefore and after the change; after deleting the lockfile the resolution is identical.CI=1 LAUNCHDARKLY_FLAG_KEY=hello-boolean bundle exec ruby main.rb→*** SDK successfully initialized!and*** The 'hello-boolean' feature flag evaluates to true.(exit 0), both before and after.ruby -W:deprecatedandruby -w: no deprecation warnings. The only warnings are upstream noise (requestor.rb:98: assigned but unused variable - media_typein the SDK, and a circular-require warning fromhttp-cookie).grep -ri deprecatover launchdarkly-server-sdk 8.18.0's source: no deprecated APIs at all, so nothing inmain.rbto migrate.Alternatives rejected / scope notes
~> 8.0already permits 8.18.0 and there is no committed lockfile, so a bump would be a no-op (and 9.x would cross the major).actions/checkout@v7,ruby/setup-rubySHA 95ef2b0 = v1.321.0 — v1.324.0 exists and is dependabot's job,verify-hello-app-v2.0.1is latest).Link to Devin session: https://app.devin.ai/sessions/4b7e0f236ef64553acbff2afe77bda16
Open in Devin Desktop: https://app.devin.ai/desktop/session/4b7e0f236ef64553acbff2afe77bda16?variant=devin
Note
Overview
Relaxes the Bundler version pin for the
loggergem in theGemfilefrom~> 1.7.0to~> 1.7, so patch releases within the 1.7+ line are allowed up to (but not including) 2.0 instead of being capped below 1.8.Resolution today should stay on 1.7.0 (latest); other gems (
launchdarkly-server-sdk,observer,benchmark) are unchanged.Reviewed by Cursor Bugbot for commit a934257. Bugbot is set up for automated code reviews on this repo. Configure here.