Skip to content

chore: float logger constraint within its current major - #32

Merged
keelerm84 merged 1 commit into
mainfrom
devin/1789981478-float-logger
Sep 21, 2026
Merged

keelerm84 merged 1 commit into
mainfrom
devin/1789981478-float-logger

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Widens the only Gemfile constraint that was locked to a single minor series so it floats within its current major, keeping today's version as the floor.

  • gem 'logger', '~> 1.7.0' → '~> 1.7' (>= 1.7.0, < 2.0); resolution is unchanged today (1.7.0 is latest).
  • launchdarkly-server-sdk '~> 8.0' left as-is — it already floats within 8.x and resolves to the latest 8.18.0.
  • observer '~> 0.1.0' and benchmark '~> 0.5.0' left as-is — 0.x minors are breaking, so they are not widened.
  • No deprecated SDK APIs in main.rb; no README or CI changes needed.
Implementation details

Versions resolved (Ruby 3.4.10 via mise, bundler 2.7.2, Gemfile.lock is gitignored so bundle install always resolves fresh):
launchdarkly-server-sdk 8.18.0 (latest), logger 1.7.0 (latest), benchmark 0.5.0 (latest), observer 0.1.2, plus transitive concurrent-ruby 1.3.8, http 6.0.4, ld-eventsource 2.6.0, json 3.0.2, openssl 4.0.2.

Testing performed

  • bundle _2.7.2_ install before and after the change; after deleting the lockfile the resolution is identical.
  • Ran the example end-to-end against the hello-apps server key with CI=1 LAUNCHDARKLY_FLAG_KEY=hello-boolean bundle exec ruby main.rb → *** SDK successfully initialized! and *** The 'hello-boolean' feature flag evaluates to true. (exit 0), both before and after.
  • Ran with ruby -W:deprecated and ruby -w: no deprecation warnings. The only warnings are upstream noise (requestor.rb:98: assigned but unused variable - media_type in the SDK, and a circular-require warning from http-cookie).
  • grep -ri deprecat over launchdarkly-server-sdk 8.18.0's source: no deprecated APIs at all, so nothing in main.rb to migrate.

Alternatives rejected / scope notes

  • No SDK version bump: ~> 8.0 already permits 8.18.0 and there is no committed lockfile, so a bump would be a no-op (and 9.x would cross the major).
  • GitHub Actions pins untouched by policy (actions/checkout@v7, ruby/setup-ruby SHA 95ef2b0 = v1.321.0 — v1.324.0 exists and is dependabot's job, verify-hello-app-v2.0.1 is latest).
  • README's documented minimum (Ruby 3.1.0+) untouched: the example works on 3.4, but nothing newer is required.

Link to Devin session: https://app.devin.ai/sessions/4b7e0f236ef64553acbff2afe77bda16
Open in Devin Desktop: https://app.devin.ai/desktop/session/4b7e0f236ef64553acbff2afe77bda16?variant=devin


Note

Overview
Relaxes the Bundler version pin for the logger gem in the Gemfile from ~> 1.7.0 to ~> 1.7, so patch releases within the 1.7+ line are allowed up to (but not including) 2.0 instead of being capped below 1.8.

Resolution today should stay on 1.7.0 (latest); other gems (launchdarkly-server-sdk, observer, benchmark) are unchanged.

Reviewed by Cursor Bugbot for commit a934257. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration
devin-ai-integration Bot requested a review from a team as a code owner September 21, 2026 09:05
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot added the devin-pr PR created by Devin label Sep 21, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

@cursor review

@keelerm84
keelerm84 merged commit 9c61861 into main Sep 21, 2026
5 checks passed
@keelerm84
keelerm84 deleted the devin/1789981478-float-logger branch September 21, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr PR created by Devin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants