-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Add environment ID support for hooks. #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kinyoklion
wants to merge
7
commits into
main
Choose a base branch
from
devin/1786559619-cpp-hook-environment-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6436533
feat: Propagate environment ID to hooks
devin-ai-integration[bot] bdbbb0c
ci: Re-run contract tests against the released test harness
devin-ai-integration[bot] 9f6f39b
ci: Re-run contract tests against the released test harness
devin-ai-integration[bot] d1cbdd5
refactor: Carry the environment ID with data payload metadata
devin-ai-integration[bot] 1ca4842
ci: Re-run after a transient dependency fetch failure
devin-ai-integration[bot] abe15ec
ci: Re-run after transient runner failures
devin-ai-integration[bot] e2ac563
refactor: Centralize the environment ID header definition
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
libs/server-sdk/src/data_systems/environment_id_header.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| #pragma once | ||
|
|
||
| #include <optional> | ||
| #include <string> | ||
| #include <utility> | ||
|
|
||
| #include <boost/beast/http/fields.hpp> | ||
|
|
||
| #include <launchdarkly/network/http_requester.hpp> | ||
|
|
||
| namespace launchdarkly::server_side::data_systems { | ||
|
|
||
| inline constexpr char const* kEnvironmentIdHeader = "X-LD-EnvID"; | ||
|
|
||
| inline std::optional<std::string> ReadEnvironmentId( | ||
| network::HttpResult::HeadersType const& headers) { | ||
| auto const it = headers.find(kEnvironmentIdHeader); | ||
| if (it == headers.end() || it->second.empty()) { | ||
| return std::nullopt; | ||
| } | ||
| return it->second; | ||
| } | ||
|
|
||
| inline std::optional<std::string> ReadEnvironmentId( | ||
| boost::beast::http::fields const& headers) { | ||
| auto const it = headers.find(kEnvironmentIdHeader); | ||
| if (it == headers.end() || it->value().empty()) { | ||
| return std::nullopt; | ||
| } | ||
| return std::string(it->value().data(), it->value().size()); | ||
| } | ||
|
|
||
| /** | ||
| * Reports the environment ID from the given response headers to the given | ||
| * destination, if the headers contain a non-empty environment ID. | ||
| */ | ||
| template <typename Destination, typename Headers> | ||
| void ReportEnvironmentId(Destination& destination, Headers const& headers) { | ||
| if (auto environment_id = ReadEnvironmentId(headers)) { | ||
| destination.SetEnvironmentId(*std::move(environment_id)); | ||
| } | ||
| } | ||
|
|
||
| } // namespace launchdarkly::server_side::data_systems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these lines changed?