fix: remove invalid 'run' key from install-curl step in cmake workflow#507
Merged
kinyoklion merged 1 commit intomainfrom Mar 10, 2026
Merged
fix: remove invalid 'run' key from install-curl step in cmake workflow#507kinyoklion merged 1 commit intomainfrom
kinyoklion merged 1 commit intomainfrom
Conversation
The test-ubuntu-curl job had both 'uses' and 'run' on the same step, which is invalid in GitHub Actions. This was introduced in commit 5b8bbee (PR #500). The install-curl composite action already handles apt-get installation internally, so the 'run' key was redundant and caused the entire workflow to fail with 0 jobs. Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
joker23
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove invalid 'run' key from cmake workflow step
Summary
The
test-ubuntu-curljob in.github/workflows/cmake.ymlhas a step with bothuses:andrun:keys, which is invalid in GitHub Actions (a step must be one or the other). This causes the entire workflow to fail immediately with 0 jobs — the root cause of the failure in run 22914048955.The invalid
run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-devwas added in PR #500 (commit 5b8bbee). It is also redundant — the.github/actions/install-curlcomposite action already runsapt-get install libcurl4-openssl-devon Linux internally.The fix simply removes the erroneous
run:line.Review & Testing Checklist for Human
apt-get(it does as of this writing)cmake-integrationworkflow runs successfully onmainwith all 6 jobs createdNotes
Note
Low Risk
Fixes a GitHub Actions YAML syntax issue in CI; no production code changes and behavior remains handled by the existing
install-curlcomposite action.Overview
Fixes the
cmake-integrationGitHub Actions workflow by removing an invalidruncommand from thetest-ubuntu-curlstep that alreadyusestheinstall-curlcomposite action.This prevents the workflow from failing to start due to an invalid step definition, while keeping curl installation delegated to
./.github/actions/install-curl.Written by Cursor Bugbot for commit 6d88ed6. This will update automatically on new commits. Configure here.