Skip to content

fix: remove invalid 'run' key from install-curl step in cmake workflow#507

Merged
kinyoklion merged 1 commit intomainfrom
devin/1773164748-fix-cmake-workflow
Mar 10, 2026
Merged

fix: remove invalid 'run' key from install-curl step in cmake workflow#507
kinyoklion merged 1 commit intomainfrom
devin/1773164748-fix-cmake-workflow

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Mar 10, 2026

fix: remove invalid 'run' key from cmake workflow step

Summary

The test-ubuntu-curl job in .github/workflows/cmake.yml has a step with both uses: and run: keys, which is invalid in GitHub Actions (a step must be one or the other). This causes the entire workflow to fail immediately with 0 jobs — the root cause of the failure in run 22914048955.

The invalid run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev was added in PR #500 (commit 5b8bbee). It is also redundant — the .github/actions/install-curl composite action already runs apt-get install libcurl4-openssl-dev on Linux internally.

The fix simply removes the erroneous run: line.

Review & Testing Checklist for Human

  • Verify the install-curl composite action still handles Linux curl installation via apt-get (it does as of this writing)
  • After merging, confirm the cmake-integration workflow runs successfully on main with all 6 jobs created

Notes


Note

Low Risk
Fixes a GitHub Actions YAML syntax issue in CI; no production code changes and behavior remains handled by the existing install-curl composite action.

Overview
Fixes the cmake-integration GitHub Actions workflow by removing an invalid run command from the test-ubuntu-curl step that already uses the install-curl composite action.

This prevents the workflow from failing to start due to an invalid step definition, while keeping curl installation delegated to ./.github/actions/install-curl.

Written by Cursor Bugbot for commit 6d88ed6. This will update automatically on new commits. Configure here.

The test-ubuntu-curl job had both 'uses' and 'run' on the same step,
which is invalid in GitHub Actions. This was introduced in commit
5b8bbee (PR #500). The install-curl composite action already handles
apt-get installation internally, so the 'run' key was redundant and
caused the entire workflow to fail with 0 jobs.

Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@kinyoklion kinyoklion marked this pull request as ready for review March 10, 2026 18:17
@kinyoklion kinyoklion requested a review from a team as a code owner March 10, 2026 18:17
@kinyoklion kinyoklion merged commit 43eff52 into main Mar 10, 2026
46 checks passed
@kinyoklion kinyoklion deleted the devin/1773164748-fix-cmake-workflow branch March 10, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants