fix(mysql): treat BINARY columns as Blob in Any type mapping#4225
Open
barry3406 wants to merge 1 commit intolaunchbadge:mainfrom
Open
fix(mysql): treat BINARY columns as Blob in Any type mapping#4225barry3406 wants to merge 1 commit intolaunchbadge:mainfrom
barry3406 wants to merge 1 commit intolaunchbadge:mainfrom
Conversation
MySQL BINARY(size) columns report ColumnType::String with the BINARY flag set. The Any driver type conversion only checked the column type without looking at flags, so BINARY columns got mapped to AnyTypeInfoKind::Text instead of Blob. This caused UTF-8 decoding errors when reading raw binary data through AnyRow. Check ColumnFlags::BINARY for String/VarString/VarChar column types and map to Blob when set. Fixes launchbadge#4132
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4132
MySQL
BINARY(size)columns reportColumnType::Stringwith theBINARYflag set. The Any driver's type conversion checked the column type but not the flags, so BINARY columns got mapped toAnyTypeInfoKind::Text. Reading raw binary data throughAnyRowthen blew up with a UTF-8 decoding error.Before:
After:
The fix checks
ColumnFlags::BINARYforString/VarString/VarCharcolumn types and maps toBlobwhen set.