sqlx-postgres: add support to abstract sockets#4174
Open
rafonseca wants to merge 1 commit intolaunchbadge:mainfrom
Open
sqlx-postgres: add support to abstract sockets#4174rafonseca wants to merge 1 commit intolaunchbadge:mainfrom
rafonseca wants to merge 1 commit intolaunchbadge:mainfrom
Conversation
PostgreSQL treats hosts starting by @ as abstract sockets (linux only). This patch modifies parse to correctly read host parameter as socket in these cases. It also modifies fetch_socket to provide the proper argument to net::connect_uds.
rafonseca
force-pushed
the
pg-abstract-sockets
branch
from
b7952ee to
477c52d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL treats hosts starting with @ as abstract sockets (linux only). This patch modifies
parseto correctly readhostparameter as socket in these cases. It also modifiesfetch_socketto provide the proper argument tonet::connect_uds.Note that in this case, we cannot pass the host in its standard form in DATABASE_URL because the @ would break the url standard syntax. Instead, we should pass the host as a query parameter (see example in test case).
Does your PR solve an issue?
There is no issue yet
Is this a breaking change?
No. It should not break anything. If someone was using a hostname starting by "@", their setup was already broken.